Skip to content

Add flash sum check #9722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

theamirocohen
Copy link
Contributor

Description

Check that flash size sum up to all sectors combined.
The sector map can be printed if wanted.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-storage

Check that flash size sum up to all sectors combined
@ciarmcom ciarmcom requested review from a team February 14, 2019 16:00
@ciarmcom
Copy link
Member

@theamirocohen, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@deepikabhavnani
Copy link

Check that flash size sum up to all sectors combined. The sector map can be printed if wanted.

I am confused regarding the purpose of the test, please share some background information. when will sector size of all sectors not match the flash size?

@davidsaada
Copy link
Contributor

Check that flash size sum up to all sectors combined. The sector map can be printed if wanted.

I am confused regarding the purpose of the test, please share some background information. when will sector size of all sectors not match the flash size?

Trigger was a flash driver we have got, that included a hard coded sector map, instead of querying the device.

@deepikabhavnani
Copy link

Trigger was a flash driver we have got, that included a hard coded sector map, instead of querying the device.

Ok, that explains. Thanks 👍

@cmonr
Copy link
Contributor

cmonr commented Feb 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 15, 2019

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 1554b0c into ARMmbed:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants