ESP8266: connect() returns OK in non-blocking calls #9741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michalpasztamobica, thank you for your changes. |
VeijoPesonen
approved these changes
Feb 18, 2019
SeppoTakalo
approved these changes
Feb 18, 2019
0xc0170
approved these changes
Feb 18, 2019
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I accidentally broke the non-blocking behavior with PR #9639. This commit brings back the previous functionality: in case of non-blocking calls, just return NSAPI_ERROR_OK. This time I ran netsocket-* and network-* to see that everything is passing (aside from what we know is not)
Pull request type
Reviewers
@SeppoTakalo
@VeijoPesonen
Release Notes