Skip to content

BLE:Cordio: ATTS setting for write cback should use bitwise or #9748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2019
Merged

BLE:Cordio: ATTS setting for write cback should use bitwise or #9748

merged 1 commit into from
Feb 19, 2019

Conversation

desmond-blue
Copy link
Contributor

Description

The attribute settings for ATTS_SET_WRITE_CBACK overwrites the setting for ATTS_SET_READ_CBACK because the assignment operator, it should use bitwise or operator.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@desmond-blue desmond-blue mentioned this pull request Feb 19, 2019
Closed
@ciarmcom ciarmcom requested review from a team February 19, 2019 08:00
@ciarmcom
Copy link
Member

@desmond-blue, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

pan-
pan- approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @desmond-blue

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 23c494b into ARMmbed:master Feb 19, 2019
@desmond-blue desmond-blue mentioned this pull request Feb 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@desmond-blue @ciarmcom @0xc0170 @mbed-ci @pan-