Skip to content

Add comment fix warning #9752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2019
Merged

Add comment fix warning #9752

merged 2 commits into from
Feb 21, 2019

Conversation

mirelachirica
Copy link
Contributor

Description

  • added explanatory comment for AT cellular stack's socket_open routine
  • remove compiling warning for BG96 cellular stack

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team February 19, 2019 12:00
@ciarmcom
Copy link
Member

@mirelachirica, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Feb 20, 2019

@ARMmbed/mbed-os-wan Please review.

@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 50af2c3 into ARMmbed:master Feb 21, 2019
@cmonr cmonr removed the needs: CI label Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mirelachirica @ciarmcom @cmonr @mbed-ci @0xc0170 @AnttiKauppila @jarvte