allow hash or mac on large buffers with less memory use #9758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation use a fixed size buffer for large inputs to process the input in multiple smaller pieces.
|
@NirSonnenschein, thank you for your changes. |
|
Needs coding style update (review Travis astyle job) |
0xc0170
approved these changes
Feb 20, 2019
| @@ -28,6 +33,12 @@ typedef struct psa_spm_hash_clone_s { | |||
| // ---------------------------------- Globals ---------------------------------- | |||
| static int psa_spm_init_refence_counter = 0; | |||
|
|
|||
| /* maximal memoty allocation for reading large hash ort mac input buffers. | |||
There was a problem hiding this comment.
oops, good catch : fixed.
alekshex
approved these changes
Feb 24, 2019
|
Ci started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously a buffer the size of whole input was allocated for hash or MAC operations which is inefficient. This change allows the use of a fixed size buffer for large inputs to process the input
in multiple smaller pieces.
Pull request type
Reviewers
@avolinski @itayzafrir
Release Notes
description: Hash and mac operations are now processed in secure partition in multiple chunks internally leading to decrease in memory use for large buffers.
effect analysis: This change has no impact on API and should not alter behavior from the user perspective.
Migration: not action should be required from the user side.