Skip to content

Add config header to assembly compilation #9765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2019
Merged

Add config header to assembly compilation #9765

merged 1 commit into from
Feb 20, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Feb 19, 2019 •
edited
Loading

Description

Add missing config header for assembly file in ARMC6.
This Fixes an inconsistency between toolchains
GCC and ARMC5 are already doing this
IAR has a solution implemented as well

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy @deepikabhavnani @mikisch81

Release Notes

@ciarmcom
Copy link
Member

@orenc17, thank you for your changes.
@mikisch81 @deepikabhavnani @theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

cmonr
cmonr approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated details!

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

CI started

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

Would still like feedback from @theotherjimmy and @mikisch81 before merging.

Should be a quick review.

theotherjimmy
theotherjimmy approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the behavior consistent for all of the compilers.

mikisch81
mikisch81 approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@mikisch81 mikisch81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orenc17
Add config header to assembly compilation
156bdc4 
ARMC6 was not including mbed_config.h when compiling assembly files
@orenc17
Copy link
Contributor Author

orenc17 commented Feb 19, 2019

Reverted the changes in IAR

@mbed-ci
Copy link

mbed-ci commented Feb 20, 2019

Test run: FAILED

Summary: 2 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR

@NirSonnenschein
Copy link
Contributor

restarted CI

@mikisch81 mikisch81 mentioned this pull request Feb 20, 2019
Merged
@mbed-ci
Copy link

mbed-ci commented Feb 20, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 3aeff7a into ARMmbed:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@mikisch81 mikisch81 mikisch81 approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@orenc17 @ciarmcom @cmonr @mbed-ci @NirSonnenschein @theotherjimmy @0xc0170 @mikisch81 @deepikabhavnani