-
Notifications
You must be signed in to change notification settings - Fork 3k
Add missing wifi parameters to test configs #9778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing wifi parameters to test configs #9778
Conversation
@michalpasztamobica, thank you for your changes. |
@michalpasztamobica What happens if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feedback echos @SeppoTakalo
5269b71
to
6bfd083
Compare
@cmonr , @SeppoTakalo , you are right, I might have overinterpreted my task... PR amended to reflect your input, thanks for that. |
Noticed some missing network parameters documentation, so added that in a separate commit, but I think it's related enough to merge both in one PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. The configuration values are up to the folks who maintain those, so if it works for you it works for me.
903fdba
to
08b06e2
Compare
@@ -26,7 +62,7 @@ | |||
"target.network-default-interface-type": "WIFI", | |||
"nsapi.default-wifi-ssid": "\"WIFI_SSID\"", | |||
"nsapi.default-wifi-password": "\"WIFI_PASSWORD\"", | |||
"nsapi.default-wifi-security": "WIFI_SECURITY", | |||
"nsapi.default-wifi-security": "WPA2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep thos configs compileable out of the box I had to change this setting.
Otherwise we get:
[Error] NetworkInterfaceDefaults.cpp@86,0: #20: identifier "NSAPI_SECURITY_WIFI_SECURITY" is undefined
@VeijoPesonen , thanks for your feedback. I just pushed a commit with "Wi-Fi" written correctly :) |
🎉 |
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Description
The point is to follow the configs as described in the documentation .
Pull request type
Reviewers
@SeppoTakalo