Crypto Service - keys access control TESTS #9780

itayzafrir · 2019-02-20T16:06:58Z

Description

Tests for crypto access control in PSA systems.

~~This PR needs preceding PR #9638~~

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@avolinski

Release Notes

ciarmcom · 2019-02-20T18:00:48Z

@itayzafrir, thank you for your changes.
@avolinski @ARMmbed/mbed-os-maintainers please review.

alekshex · 2019-02-24T11:31:28Z

TESTS/psa/crypto_access_control/COMPONENT_SPE/test_partition.c

+    read_input_param_from_message(msg, 1, &key_type);
+    read_input_param_from_message(msg, 2, &key_data_size);
+
+    key_data = calloc(1, key_data_size);


where key_data is being freed?

oops :(
added in 391ff6135acbb28bd7797e847b7556f9dee0763c

alekshex · 2019-02-24T11:43:13Z

TESTS/psa/crypto_access_control/COMPONENT_NSPE/main.cpp

+
+    /* via test partition - create a key, set key policy but no key material */
+    key_handle = 0;
+    TEST_ASSERT_EQUAL(PSA_SUCCESS, test_partition_crypto_create_persistent_key(key_id, &key_handle));


when is this key destroyed?

All ITS keys are being erased in case_setup_handler and case_teardown_handler.

alekshex · 2019-02-24T13:00:30Z

TESTS/psa/crypto_access_control/COMPONENT_NSPE/main.cpp

+    size_t len;
+
+    /* via test partition - create a key, set key policy, generate key material and close */
+    TEST_ASSERT_EQUAL(PSA_SUCCESS, create_and_generate_key_via_test_partition(key_id, key_type, key_alg, key_usage,


were is teardown for this key?

All ITS keys are being erased in case_setup_handler and case_teardown_handler.

alekshex · 2019-02-24T13:00:39Z

TESTS/psa/crypto_access_control/COMPONENT_NSPE/main.cpp

+    psa_cipher_operation_t operation;
+
+    /* via test partition - create a key, set key policy, generate key material and close */
+    TEST_ASSERT_EQUAL(PSA_SUCCESS, create_and_generate_key_via_test_partition(key_id, key_type, key_alg, key_usage,


were is teardown for this key?

All ITS keys are being erased in case_setup_handler and case_teardown_handler.

itayzafrir · 2019-02-24T13:37:47Z

rebased on master + aligned with updated error codes

cmonr · 2019-02-27T05:13:57Z

CI started

itayzafrir · 2019-02-27T05:45:07Z

CI won't pass now, this needs preceding PR #9638

mbed-ci · 2019-02-27T09:12:59Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

0xc0170 · 2019-02-27T09:15:21Z

It did pass, what do we miss?

itayzafrir · 2019-02-27T09:35:29Z

It did pass, what do we miss?

There was no reason for compilation to break, but running the tests would have failed. AFAIK for targets which are FUTURE_SEQUANA_PSA tests are only built and not run, correct me if I'm wrong.

itayzafrir · 2019-02-27T10:02:37Z

Rebased on master & added a7efc0e which aligns error code handling to latest standards.

itayzafrir · 2019-02-27T14:00:10Z

#9638 is merged, this PR is unblocked now.

0xc0170 · 2019-02-27T14:17:34Z

CI started

mbed-ci · 2019-02-27T15:19:16Z

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC6
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM

alekla01 · 2019-02-27T15:20:53Z

Restarted CI.

mbed-ci · 2019-02-27T16:14:30Z

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM

itayzafrir · 2019-02-27T16:36:45Z

CI failure doesn't seem to be directly related to the changes in this PR.

Rebased branch on master & added 2 new commits:

Fix for test asymmetric encrypt decrypt (5f3989bec701f156cb666017725b8a4a5a27c57a)
Update secure side binary hex (b124ae2c28286ff17d10d88eb31c0d4977506ccc)

cmonr · 2019-02-27T17:58:54Z

CI restarted

mbed-ci · 2019-02-27T19:27:26Z

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM

cmonr · 2019-02-27T19:41:20Z

@itayzafrir Please take a look at the NUMAKER_PFM_M2351 ARM build failure.

cmonr · 2019-02-27T23:00:02Z

Info: A CI config issue appears to be affecting NUMAKER_PFM_M2351 builds. Please ignore build errors against the target for now.

Other build failures should still be investigated, if any. Will restart CI when appropriate.

0xc0170 · 2019-02-28T11:29:37Z

CI restarted

mbed-ci · 2019-02-28T15:57:36Z

Test run: FAILED

Summary: 2 of 13 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test
jenkins-ci/mbed-os-ci_exporter

itayzafrir · 2019-02-28T16:05:57Z

CI failures don't seem to be related to changes in this PR:

| K66F-IAR | K66F | components-storage-blockdevice-component_sd-tests-filesystem-parallel | FAIL | 74.5 | default |
Exporter -> IAR -> NUMAKER_PFM_NUC472

alekla01 · 2019-02-28T16:24:06Z

@0xc0170: Ci will be restarted (iar8 exporter issue we will resolve separately).

ciarmcom requested review from alekshex and a team February 20, 2019 18:00

ciarmcom added the needs: review label Feb 20, 2019

NirSonnenschein added needs: preceding PR release-version: 5.12.0-rc1 labels Feb 20, 2019

alekshex reviewed Feb 24, 2019

View reviewed changes

itayzafrir force-pushed the crypto-access-control-tests branch from 3b4d187 to c75ede1 Compare February 24, 2019 13:37

alekshex approved these changes Feb 24, 2019

View reviewed changes

0xc0170 added the risk: A label Feb 25, 2019

cmonr added risk: R and removed risk: A labels Feb 25, 2019

NirSonnenschein approved these changes Feb 26, 2019

View reviewed changes

NirSonnenschein added needs: CI and removed needs: review labels Feb 26, 2019

itayzafrir force-pushed the crypto-access-control-tests branch from 391ff61 to a7efc0e Compare February 27, 2019 10:00

0xc0170 removed the needs: preceding PR label Feb 27, 2019

0xc0170 approved these changes Feb 27, 2019

View reviewed changes

itayzafrir added 4 commits February 27, 2019 16:28

Add acl test - use other partitions' key - asymmetric sign verify

5a7ed31

Add acl test - use other partitions' key - asymmetric encrypt decrypt

2227e33

Add pre-built hex file for secure side tests

4764b55

Free dynamic memory in test partition

2918f74

itayzafrir force-pushed the crypto-access-control-tests branch from a7efc0e to b124ae2 Compare February 27, 2019 16:34

cmonr added needs: work and removed needs: CI labels Feb 27, 2019

cmonr added needs: CI and removed needs: work labels Feb 27, 2019

itayzafrir added 3 commits February 28, 2019 10:29

Change error code handling of calls to psa_call

31d202b

Fix acl test asymmetric encrypt decrypt

b8bdaf9

Update pre-built hex file for secure side tests

02f5918

itayzafrir force-pushed the crypto-access-control-tests branch from b124ae2 to 02f5918 Compare February 28, 2019 08:30

mikisch81 mentioned this pull request Feb 28, 2019

mbed-SPM updates #9823

Merged

cmonr added ready for merge and removed needs: CI labels Feb 28, 2019

cmonr merged commit 486f4f5 into ARMmbed:master Mar 1, 2019

cmonr removed the ready for merge label Mar 1, 2019

Crypto Service - keys access control TESTS #9780

Crypto Service - keys access control TESTS #9780

Uh oh!

Conversation

itayzafrir commented Feb 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Feb 20, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

itayzafrir Feb 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

itayzafrir commented Feb 24, 2019

Uh oh!

cmonr commented Feb 27, 2019

Uh oh!

itayzafrir commented Feb 27, 2019

Uh oh!

mbed-ci commented Feb 27, 2019

Uh oh!

0xc0170 commented Feb 27, 2019

Uh oh!

itayzafrir commented Feb 27, 2019

Uh oh!

itayzafrir commented Feb 27, 2019

Uh oh!

itayzafrir commented Feb 27, 2019

Uh oh!

0xc0170 commented Feb 27, 2019

Uh oh!

mbed-ci commented Feb 27, 2019

Uh oh!

alekla01 commented Feb 27, 2019

Uh oh!

mbed-ci commented Feb 27, 2019

Uh oh!

itayzafrir commented Feb 27, 2019

Uh oh!

cmonr commented Feb 27, 2019

Uh oh!

mbed-ci commented Feb 27, 2019

Uh oh!

cmonr commented Feb 27, 2019

Uh oh!

cmonr commented Feb 27, 2019

Uh oh!

0xc0170 commented Feb 28, 2019

Uh oh!

mbed-ci commented Feb 28, 2019

Uh oh!

itayzafrir commented Feb 28, 2019

Uh oh!

alekla01 commented Feb 28, 2019

Uh oh!

Uh oh!

itayzafrir commented Feb 20, 2019 •

edited

Loading

itayzafrir Feb 24, 2019 •

edited

Loading