Added macros to alias the endpoint callback functions to support configurability #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
added a commit
that referenced
this pull request
Apr 8, 2015
USB - Add macros to alias the endpoint callback functions to support configurability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros exist in each of the USBEndpoints_.h files for assigning default endpoints for bulk, interrupt and isochronous functions. These macros are used by the various device classes. The callback functions in the classes, however, are hard coded to specific endpoint numbers. I have added additional macros to alias the callback functions to ensure that they match the assigned endpoints for a given target.
All currently supported USBDevice targets have used the same endpoint assignments, so no problem has arisen. We are currently working on adding a new target in which the endpoint assignments will be different from the other targets and encountered this issue.