Skip to content

Feature iar8 rebase - Storage test fix #9818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

deepikabhavnani
Copy link

Description

DO NOT MERGE

Commit - f7a6d25 is added on top of feature-iar8 rebase PR #9811

Random number generation API's - rand() and srand() are made sparse to not have same block.

Failure was noted when 2 threads getting same random number were trying to write to same block and rechecking resulted in error (since block was over-written by another thread).

Instead of checking the same random data written, checksum logic can be used in future. Threads are allowed to overwrite the data (block commands are not in mutex) in test, so instead of verifying the exact data some checksum of data should be checked to make sure data was not jumbled up 2-threads accessing it.

Pull request type

[] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-storage

@deepikabhavnani
Copy link
Author

Started CI to check the fix

@mbed-ci
Copy link

mbed-ci commented Feb 23, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 24, 2019

As this is targeting feature iar8 and the fix for storage is separate , this shall be good to go and the fix will be taken separately (feature iar8 still needs some work).

@NirSonnenschein NirSonnenschein merged commit f7a6d25 into ARMmbed:feature-iar8 Feb 24, 2019
@NirSonnenschein
Copy link
Contributor

pushed to branch

@deepikabhavnani deepikabhavnani deleted the feature-iar8-rebase branch February 24, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants