Skip to content

PSOC6: send HCI reset after patch RAM download #9821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2019
Merged

PSOC6: send HCI reset after patch RAM download #9821

merged 1 commit into from
Feb 25, 2019

Conversation

cydriftcloud
Copy link
Contributor

@cydriftcloud cydriftcloud commented Feb 23, 2019 •
edited
Loading

Description

After the patch RAM download is completed, an HCI reset should be sent in order to initialize the registers. Some of the initialization won't be called if the HCI reset is not sent after firmware download.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo

Release Notes

@cydriftcloud
PSOC6: send HCI reset after patch RAM download
a47b365 
After the patch RAM download is completed, a HCI reset should be sent in order to initialize the registers. Some of the initialization won't be called if the HCI reset is not sent after firmware download.
@cydriftcloud cydriftcloud force-pushed the send-hci-reset-after-patchram-download branch from e102b90 to a47b365 Compare February 23, 2019 07:49
@kask01
Copy link

kask01 commented Feb 23, 2019

Changes look fine to me. Thanks.

@NirSonnenschein NirSonnenschein requested review from SeppoTakalo and a team February 25, 2019 08:02
@pan-
Copy link
Member

pan- commented Feb 25, 2019 •
edited
Loading

@cydriftcloud Could you provide more details about what is being solved ?
@NirSonnenschein This PR affects BLE, it would be interesting to asks the @ARMmbed/mbed-os-pan team about it.

@kask01
Copy link

kask01 commented Feb 25, 2019

@pan-
While testing a BT/WiFi coex scenario with BLE in central role, the BLE connections are not sustained in the presence of WiFi. Per the recommendation of our coex team, we are expected to send a HCI reset post firmware download to initialize the BT system. On reviewing the HCIDriver.cpp for 43xxx chips, we observed that this command was missing. The patch addresses that issue. Hope this clarifies.

@0xc0170 0xc0170 requested a review from a team February 25, 2019 09:25
@pan-
Copy link
Member

pan- commented Feb 25, 2019

@kask01 Thanks, that makes more sense now.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 25, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 2b811da into ARMmbed:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1 risk: G
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cydriftcloud @kask01 @pan- @0xc0170 @mbed-ci @SeppoTakalo @cmonr @NirSonnenschein