Skip to content

Update 802.15.4 RF drivers to the latest version #9828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 28, 2019
Merged

Update 802.15.4 RF drivers to the latest version #9828

merged 4 commits into from
Feb 28, 2019

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Feb 25, 2019 •
edited
Loading

Description

Update 802.15.4 RF drivers to the latest version for Mbed OS 5.12.

  • Atmel RF driver v3.0.6
  • MCR20a RF driver v1.0.3
  • STM S2LP RF driver v0.0.2

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@JarkkoPaso , @SeppoTakalo @mikter

SeppoTakalo
SeppoTakalo reviewed Feb 25, 2019
View reviewed changes
components/802.15.4_RF/atmel-rf-driver/source/NanostackRfPhyAtmel.cpp
static const phy_rf_channel_configuration_s phy_24ghz = {2405000000U, 5000000U, 250000U, 16U, M_OQPSK};
static const phy_rf_channel_configuration_s phy_subghz = {868300000U, 2000000U, 250000U, 11U, M_OQPSK};
static const phy_rf_channel_configuration_s phy_24ghz = {.channel_0_center_frequency = 2405000000U, .channel_spacing = 5000000U, .datarate = 250000U, .number_of_channels = 16U, .modulation = M_OQPSK};
static const phy_rf_channel_configuration_s phy_subghz = {.channel_0_center_frequency = 868300000U, .channel_spacing = 2000000U, .datarate = 250000U, .number_of_channels = 11U, .modulation = M_OQPSK};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is C99, but should not be legal in C++
https://stackoverflow.com/questions/18731707/why-does-c11-not-support-designated-initializer-lists-as-c99

@artokin
Copy link
Contributor Author

artokin commented Feb 25, 2019

CI compilation errors happens because new Nanostack API is needed. Nanostack will be published in separate PR.

@ciarmcom ciarmcom requested review from JarkkoPaso, mikter, SeppoTakalo and a team February 25, 2019 10:00
@ciarmcom
Copy link
Member

@artokin, thank you for your changes.
@JarkkoPaso @SeppoTakalo @mikter @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@artokin
Copy link
Contributor Author

artokin commented Feb 25, 2019

Requires API changes are available in PR #9838

@cmonr
Copy link
Contributor

cmonr commented Feb 25, 2019

@artokin Mind adding Release Notes?

@artokin
Copy link
Contributor Author

artokin commented Feb 26, 2019

@cmonr , this PR syncs 802.15.4 RF drivers from the master copy. Changes do not require release notes and therefore Release Notes header is now removed.

@artokin artokin force-pushed the update_802154_rf_drivers branch from 83151fb to 05dc1f2 Compare February 27, 2019 13:00
@artokin
Copy link
Contributor Author

artokin commented Feb 27, 2019

Rebased to get dependency PR #9838 included to the build.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2019

@ARMmbed/mbed-os-test Can you review above failure? I can't spot it in the logs (only that nanostack fails to build for M2351 target) . @artokin Please review

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2019

Info: A CI config issue appears to be affecting NUMAKER_PFM_M2351 builds. Please ignore build errors against the target for now.

Other build failures should still be investigated, if any. Will restart CI when appropriate.

@artokin
Copy link
Contributor Author

artokin commented Feb 28, 2019

I can't find any other build failure than the NUMAKER_PFM_M2351.
NUMAKER_PFM_M2351:ARM seems to fail also in the following builds and therefore it is not related to this PR. Few previous builds were using NUMAKER_PFM_M2351:ARMC6 and then that target was passing.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2019

@artokin wait a second, there's misconfig in CI, will be fixed soon

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 28, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2019

Test passed but old hook is still present (ARM build job)

@alekla01
Copy link
Contributor

@0xc0170 fixed

@0xc0170 0xc0170 merged commit 211db10 into ARMmbed:master Feb 28, 2019
@artokin artokin deleted the update_802154_rf_drivers branch March 1, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@JarkkoPaso JarkkoPaso JarkkoPaso approved these changes

@mikter mikter Awaiting requested review from mikter

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1 risk: A
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@artokin @ciarmcom @cmonr @0xc0170 @mbed-ci @alekla01 @SeppoTakalo @JarkkoPaso