Skip to content

Merge SPIF & QSPIF components test to general block device tests #9855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Merge SPIF & QSPIF components test to general block device tests #9855

wants to merge 1 commit into from

Conversation

theamirocohen
Copy link
Contributor

Description

The SPIF and QPIF components tests are fully merged into general block device tests and were deleted

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-storage

Merge SPIF & QSPIF components test to general block device tests
4abe288 
The SPIF and QPIF components tests are fully merged into general block device tests and were deleted
This was referenced Feb 26, 2019
Closed
Merged
@0xc0170 0xc0170 requested a review from a team February 26, 2019 15:08
yossi2le
yossi2le approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciarmcom ciarmcom requested review from a team February 26, 2019 16:00
@ciarmcom
Copy link
Member

@theamirocohen, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@deepikabhavnani deepikabhavnani mentioned this pull request Feb 26, 2019
Merged
@deepikabhavnani
Copy link

This PR is added to rollup PR #9858, for testing in CI.

@cmonr
Copy link
Contributor

cmonr commented Feb 26, 2019

Closing since the Rollup PR and feature-iar8 is now merged into master (5c7f6cb)

The PR wasn't auto-closed since the commit was cherry-picked instead of merged.

@cmonr cmonr closed this Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@dannybenor dannybenor dannybenor approved these changes

@yossi2le yossi2le yossi2le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@theamirocohen @ciarmcom @deepikabhavnani @cmonr @0xc0170 @dannybenor @yossi2le