QSPI write alignment fix for nRF52x #9866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@j3hill, thank you for your changes. |
offirko
approved these changes
Feb 27, 2019
0xc0170
reviewed
Feb 27, 2019
| if (ret != NRF_SUCCESS ) { | ||
| return QSPI_STATUS_ERROR; | ||
| } | ||
| pos+=diff; |
There was a problem hiding this comment.
small change request : following coding style, using space around operators (pos < *length) and similar
There was a problem hiding this comment.
I've made the change, and I'll be sure to make the spacing consistent going forward.
If the data buffer for a write is not 4-byte aligned, use an aligned 16 byte buffer on the stack
0xc0170
approved these changes
Mar 1, 2019
|
CI started while idle and waiting for master fix . |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
0xc0170
added
ready for merge
release-version: 5.12.0-rc1
and removed
needs: CI
release-version: 5.12.1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the start address of the data buffer for a QSPI write operation is not WORD/4-byte aligned, use an aligned 16 x WORD length buffer on the stack
Pull request type