Lock sleep when USB is initialized #9879
Merged
+34
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonr
approved these changes
Feb 27, 2019
cmonr
added
release-version: 5.12.1
release-version: 5.12.0-rc1
and removed
release-version: 5.12.1
labels
None of the USB drivers currently support entering deep sleep mode while USB is active. To protect USB from malfunctioning lock deep sleep in USBPhyHw::init.
c1728p9
force-pushed
the
usb_sleep_lock
branch
from
e6f0cf7 to
8ffbe5c
Compare
|
Updated this PR to move the locking into vendor specific code. If their hardware supports automatic wake from deep sleep upon reception of USB traffic and software support for this is added then these locks can be removed. |
cmonr
approved these changes
Feb 28, 2019
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
AGlass0fMilk
added a commit
to AGlass0fMilk/mbed-os
that referenced
this pull request
Mar 15, 2019
Added logic to lock deep sleep when USB is initialized to prevent malfunctioning. This is consistent with the other drivers. See PR ARMmbed#9879
AGlass0fMilk
added a commit
to AGlass0fMilk/mbed-os
that referenced
this pull request
Apr 29, 2019
Added logic to lock deep sleep when USB is initialized to prevent malfunctioning. This is consistent with the other drivers. See PR ARMmbed#9879
AGlass0fMilk
added a commit
to AGlass0fMilk/mbed-os
that referenced
this pull request
May 28, 2019
Added logic to lock deep sleep when USB is initialized to prevent malfunctioning. This is consistent with the other drivers. See PR ARMmbed#9879
hugueskamba
pushed a commit
to hugueskamba/mbed-os
that referenced
this pull request
Jun 26, 2019
Added logic to lock deep sleep when USB is initialized to prevent malfunctioning. This is consistent with the other drivers. See PR ARMmbed#9879
artokin
pushed a commit
that referenced
this pull request
Jul 3, 2019
Added logic to lock deep sleep when USB is initialized to prevent malfunctioning. This is consistent with the other drivers. See PR #9879
evedon
pushed a commit
that referenced
this pull request
Jul 11, 2019
Added logic to lock deep sleep when USB is initialized to prevent malfunctioning. This is consistent with the other drivers. See PR #9879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lock sleep when USB is initialized to ensure USB always has a clock lock deep sleep while it is in use. Thanks @rajkan01 for finding this.
Pull request type
Reviewers
@rajkan01