Skip to content

ESP8266: astyle fixes #9893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2019
Merged

ESP8266: astyle fixes #9893

merged 1 commit into from
Mar 14, 2019

Conversation

VeijoPesonen
Copy link
Contributor

Description

astyle fixes

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@michalpasztamobica

Release Notes

@ciarmcom ciarmcom requested review from michalpasztamobica and a team February 28, 2019 18:00
@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

cmonr
cmonr approved these changes Feb 28, 2019
View reviewed changes
@VeijoPesonen
Copy link
Contributor Author

@cmonr rebased.

0xc0170
0xc0170 approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for less astyle ignore files

michalpasztamobica
michalpasztamobica approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis seems to complain about one more astyle issue, but this is generally all good :)

@VeijoPesonen
Copy link
Contributor Author

Check, and then check again... Fixed, please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 9, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 17f8bc1 into ARMmbed:master Mar 14, 2019
@VeijoPesonen VeijoPesonen deleted the wifi_astyle_unignore branch March 14, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VeijoPesonen @ciarmcom @0xc0170 @mbed-ci @cmonr @SeppoTakalo @michalpasztamobica