-
Notifications
You must be signed in to change notification settings - Fork 3k
Pr/cy mbed os 5.12.0 #9908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr/cy mbed os 5.12.0 #9908
Conversation
We believe there is a problem with the following test suite: Explaination of bug in TDBStore.cpp TDBStore::init(): When check_erase_before_write occurs, it erases 2 sectors offset by 1 sector. |
@ARMmbed/mbed-os-storage Please review the above test comment (#9908 (comment)) |
@morser499 Do y'all have local test runs for the new targets against the three compilers? |
TESTS/mbed_hal/spm/main.cpp
Outdated
@@ -23,8 +23,8 @@ | |||
#error [NOT_SUPPORTED] this test is supported on GCC only | |||
#endif | |||
|
|||
#if defined(TARGET_FUTURE_SEQUANA_PSA) | |||
#error [NOT_SUPPORTED] Disable this Test until FUTURE_SEQUANA_PSA enables Memory protection | |||
#if defined(TARGET_FUTURE_SEQUANA_PSA) || defined(TARGET_CY8CKIT_062_WIFI_BT_PSA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet. Our tests are still running
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable this test please
Your platform has memory separation enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -0,0 +1,123 @@ | |||
/* mbed Microcontroller Library | |||
* Copyright (c) 2017-2017 ARM Limited | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPDX identifier for new files please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Fixes to PinNamesTypes.h and PortNames.h files from TARGET_Cypress\TARGET_PSOC6 will be merged to the PR on Monday.
targets/targets.json
Outdated
@@ -7965,12 +8019,21 @@ | |||
"network-default-interface-type": "WIFI" | |||
} | |||
}, | |||
"CYW943012P6EVB_01_M0": { | |||
"inherits": ["MCU_PSOC6_M0"], | |||
"supported_toolchains": ["GCC_ARM", "ARM", "IAR"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to specify supported_toolchains here as the parent MCU_PSOC6 already defines the same toolchain set as here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have switched to ARMC6, these entries for supported_toolchains must change.
Cypress targets ares still using ARM compiler 5, and should change all "ARM" entries to "ARMC5" in supported_toolchains. Please make this change for all Cypress targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
targets/targets.json
Outdated
"post_binary_hook": { | ||
"function": "PSOC6Code.complete" | ||
} | ||
}, | ||
"CYW943012P6EVB_01": { | ||
"inherits": ["MCU_PSOC6_M4"], | ||
"features": ["BLE"], | ||
"supported_toolchains": ["GCC_ARM", "ARM", "IAR"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to specify supported_toolchains here as the parent MCU_PSOC6 already defines the same toolchain set as here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Can you tell the sector size, page size and the size of the internal flash? |
@@ -0,0 +1,23 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this relevant to your target please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -0,0 +1,36 @@ | |||
# Copyright (c) 2017-2018 ARM Limited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore, targets.json defines a delivery_dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file removed
Please also attach test results for all 3 toolchains (as this is new target addition) |
cde08a9
to
5741434
Compare
We are observing a compilation failure with COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.c under IAR. Other toolchains work fine. Compile: C:/Program Files (x86)/IAR Systems/Embedded Workbench 8.0/arm\bin\iccarm --no_wrap_diagnostics -e --diag_suppress=Pa050,Pa084,Pa093,Pa082 -Oh --enable_restrict -DMBED_TRAP_ERRORS_ENABLED=1 --cpu Cortex-M0+ --thumb --dlib_config DLib_Config_Full.h --vla --diag_suppress=Pe546 -DTARGET_CY8CKIT_062_WIFI_BT_M0 -DTARGET_PSA -DMBEDTLS_PSA_CRYPTO_SPM -DTARGET_PSA_Target -D__MBED__=1 -DTARGET_LIKE_MBED -DDEVICE_PORTINOUT=1 -D__MBED_CMSIS_RTOS_CM -DTARGET_NAME=CY8CKIT_062_WIFI_BT_M0_PSA -DCOMPONENT_FLASHIAP=1 -DDEVICE_RTC=1 -DDEVICE_SERIAL_ASYNCH=1 -D__CMSIS_RTOS -DMBED_MPU_CUSTOM -DCY8C6247BZI_D54 -DTARGET_SPE_Target -DDEVICE_USTICKER=1 -DDEVICE_I2C=1 -DDEVICE_CRC=1 -DTARGET_CORTEX_M -DTARGET_M0P -DDEVICE_ANALOGOUT=1 -DTARGET_PSOC6 -DMBEDTLS_ENTROPY_NV_SEED -DMBED_BUILD_TIMESTAMP=1551454731.09 -DMCU_PSOC6_M0 -DDEVICE_LPTICKER=1 -DTOOLCHAIN_IAR -DPSOC6_DYNSRM_DISABLE=1 -DCOMPONENT_SPE=1 -DMBED_TICKLESS -DDEVICE_INTERRUPTIN=1 -DTARGET_MCU_PSOC6_M0 -DCOMPONENT_PSA_SRV_IMPL=1 -DTARGET_CORTEX -DTARGET_CY8CKIT_062_WIFI_BT_M0_PSA -DDEVICE_PORTOUT=1 -D__CORTEX_M0PLUS -DDEVICE_STDIO_MESSAGES=1 -DDEVICE_PWMOUT=1 -DDEVICE_SPI_ASYNCH=1 -DTARGET_CY8C62XX -DTARGET_FF_ARDUINO -DTARGET_RELEASE -DCY_IPC_DEFAULT_CFG_DISABLE -DDEVICE_SERIAL_FC=1 -DTARGET_CY8CKIT_062_WIFI_BT -DMBEDTLS_PSA_CRYPTO_C -DDEVICE_TRNG=1 -DARM_MATH_CM0PLUS -DDEVICE_PORTIN=1 -DDEVICE_SLEEP=1 -DTARGET_MCU_PSOC6 -DCOMPONENT_PSA_SRV_IPC=1 -DDEVICE_SPI=1 -DTARGET_MBED_SPM -DTARGET_Cypress -DDEVICE_ANALOGIN=1 -DDEVICE_SERIAL=1 -DDEVICE_FLASH=1 -DDEVICE_I2C_ASYNCH=1 -DCOMPONENT_SPM_MAILBOX=1 -DTARGET_LIKE_CORTEX_M0 -f .\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR.includes_70d6569d1107ac5e98f019d4cdd3dc01.txt --preinclude=.\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\mbed_config.h --dependencies BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.d -l BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.s.txt -o BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.o .\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.c
File "C:\Users\ohks\Projects\mbed-os\tools\test_exporters.py", line 92, in report |
Flash Size = 1M |
@mikisch81 @orenc17 Please review |
5741434
to
f8720a3
Compare
|
Thank you. In this case (page size equal to sector size), it's a known problem in that test, which we plan to have a PR fixing it today or tomorrow. |
I am trying to compile the mbed-os bootloader for the CY8CKIT_062_WIFI_BT and CY8CKIT_062_BLE boards and currently I found out that the following code at gpio_init is calling RTOS: `
` Is there any possibility to overcome this issue? Cause compiling RTOS will have a significant impact on code size. |
5c12c3c
to
4c1ff13
Compare
The changes have been made and added to the PR. We are in the process of running the updated tests and will post them as soon as they finish. |
@morser499 any updates wrt PSA test results? |
@cmonr can it go to CI? |
I have results for IAR; the other toolchains are still running |
Results for psa,mbed-crypto,spm on IAR |
@volodymyrbotsian could you try running the failed test again? seems like a flashing issue |
@orenc17 sure, I'll rerun |
Results for psa,mbed-crypto,spm on ARM |
Attached are the log files for all 3 runs. NOTE: This includes the re-run IAR test which is still showing the same timeout failure. CY8CKIT_062_WIFI_BT_PSA__PSA__ARM.log |
Will start CI to see where this is at whilst the last test is sorted out. |
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Waiting for approvals |
@orenc17 @mikisch81 I marked this as ready for merge but would like to know what are these timeouts in the tests. Would these block this PRs - suggestions? |
@alzix |
It can be addressed on Sunday, would be good to create a tracking issue. Ready for integration now |
Thanks! Can you open a jira ticket for us? (Not near PC right now) |
Done, #10007 |
Description
Pull request type