Skip to content

BLE:Cordio:Fix insert characteristic not handle error #9921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2019
Merged

BLE:Cordio:Fix insert characteristic not handle error #9921

merged 1 commit into from
Mar 17, 2019

Conversation

desmond-blue
Copy link
Contributor

Description

The API GattServer::insert_characteristic_value_attribute() throws BLE_ERROR_NO_MEM but the caller GattServer::insert_characteristic() doesn't handle this, and that causes attributes be added wrongly and users aren't aware of this.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@desmond-blue desmond-blue mentioned this pull request Mar 4, 2019
Closed
@ciarmcom ciarmcom requested review from a team March 4, 2019 04:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 4, 2019

@desmond-blue, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

pan-
pan- requested changes Mar 4, 2019
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do the same with the calls to insert_descriptor and insert_cccd made in that function ?

@desmond-blue desmond-blue force-pushed the fix_Cordio-insert-characteristic-handle-error branch from 5108fd2 to 10d09b2 Compare March 5, 2019 01:56
@desmond-blue desmond-blue force-pushed the fix_Cordio-insert-characteristic-handle-error branch from 10d09b2 to 3fe18a1 Compare March 5, 2019 01:57
@desmond-blue
Copy link
Contributor Author

@pan- Thanks for suggestion, the changes are applied.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019
Merge pull request ARMmbed#9921 from null
cd5f690 
null
cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019
Merge pull request ARMmbed#9921 from desmond-blue/fix_Cordio-insert-c…
edf39cb 
…haracteristic-handle-error

BLE:Cordio:Fix insert characteristic not handle error
@cmonr cmonr merged commit 7fa9958 into ARMmbed:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@desmond-blue @ciarmcom @0xc0170 @mbed-ci @pan- @cmonr