Skip to content

Reduce number of threads in block device test #9931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2019
Merged

Reduce number of threads in block device test #9931

merged 3 commits into from
Mar 6, 2019

Conversation

offirko
Copy link
Contributor

@offirko offirko commented Mar 4, 2019 •
edited
Loading

Description

Storage Tests Fix:

  1. Prevent FS tests from running on internal FlashIAP
  2. Reduce number of threads for general BD multi-thread test
    and verify memory resources before running test

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@offirko
Copy link
Contributor Author

offirko commented Mar 4, 2019

@ARMmbed/mbed-os-storage
@ARMmbed/mbed-os-maintainers
I'd appreciate your review

@mikisch81
Copy link
Contributor

@mmahadevan108 FYI

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2019 •
edited
Loading

As outsider for these tests - a reason for reducing the test coverage (not enabling to run on internal flash) ? should be in the commit msg ?

Was there a problem ?

@dannybenor
Copy link

Filesystem is not intended to work in internal flash, even if the test works. We want to avoid spending time fixing tests or code that should not be part of our offer. The solution for internal flash is TDBStore

@ciarmcom ciarmcom requested review from a team March 4, 2019 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 4, 2019

@offirko, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@mikisch81
Copy link
Contributor

mikisch81 commented Mar 4, 2019 •
edited
Loading

@ARMmbed/mbed-os-maintainers @maclobdell @amiraloosh this is needed for #9910 (new PSA target) so it needs to have 5.12 label

theamirocohen
theamirocohen suggested changes Mar 5, 2019
View reviewed changes
features/storage/TESTS/blockdevice/general_block_device/main.cpp Outdated
char *dummy;

rtos::Thread **bd_thread = new (std::nothrow) rtos::Thread*[TEST_NUM_OF_THREADS];
TEST_SKIP_UNLESS_MESSAGE((*bd_thread) != NULL, "no block device found.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message should reflect the skip reason

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Please re-review.

@0xc0170 0xc0170 requested a review from a user March 5, 2019 12:57
@ghost ghost added the PM_ACCEPTED label Mar 5, 2019
ghost
ghost approved these changes Mar 5, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets PM Criteria - targeted fix.

@cmonr
Copy link
Contributor

cmonr commented Mar 5, 2019

Please update this commit 1f756ec such that the reasoning in this comment is added: #9931 (comment)

It makes figuring out why a skip was added considerably easier, since searching for the PR where that change was introduced is not easy.

cmonr
cmonr suggested changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9931 (comment)

Can start CI once corrected.

offirko and others added 3 commits March 5, 2019 22:40
Reduce number of threades in block device test
e411187 
In addition, prevent FS tests from running on internal flash,
due to the fact that file system on internal flash is not part of
our offering (TDBStore should be used there instead).
Add pre test resource verifications
4075d6e
Fix test skip message to not enough heap
3c14dd4
@davidsaada
Copy link
Contributor

#9931 (comment)

Can start CI once corrected.

Corrected now.

@cmonr
Copy link
Contributor

cmonr commented Mar 5, 2019

CI started for now.

Suspect export issue is still a problem, but that job can be restarted once fixed.

@cmonr cmonr changed the title Reduce number of threades in block device test Reduce number of threads in block device test Mar 5, 2019
@mbed-ci
Copy link

mbed-ci commented Mar 5, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 26920fe into ARMmbed:master Mar 6, 2019
@cmonr cmonr removed the needs: CI label Mar 6, 2019
@offirko
Copy link
Contributor Author

offirko commented Mar 6, 2019

Issue created to handle the TFM threads limitation:
https://jira.arm.com/browse/IOTSEC-1120

@mikisch81 mikisch81 mentioned this pull request Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsaada davidsaada davidsaada left review comments

@theamirocohen theamirocohen theamirocohen requested changes

@cmonr cmonr cmonr approved these changes

@dannybenor dannybenor dannybenor approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@offirko @mikisch81 @0xc0170 @dannybenor @ciarmcom @cmonr @davidsaada @mbed-ci @theamirocohen