-
Notifications
You must be signed in to change notification settings - Fork 3k
Add missing RSPIF component to the defaut BlockDevice handler #9941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@marcuschangarm, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For which target do you want to define rspif as default?
When compiling the bootloader. |
I think this code will better fit the bootloader than a central place. If we will not have the special components in targets.json, it is better to allocate according to the real parallel component. If spif then the bootloader will allocate rspif. |
Wouldn't that be an anti-pattern for the user experience, though? Right now we teach our users to set the default blockdevice using the configurations system. It works for all blockdevices in components, except this one. |
Bootloader is not intended to be built by users. They should use a ready made binary |
@dannybenor I've sent you a message on Slack. |
Ci started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Description
Add missing support for RSPIF when using
BlockDevice::get_default_instance()
.Pull request type
Reviewers
Release Notes