Skip to content

Add missing RSPIF component to the defaut BlockDevice handler #9941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Add missing RSPIF component to the defaut BlockDevice handler #9941

merged 1 commit into from
Mar 15, 2019

Conversation

marcuschangarm
Copy link
Contributor

Description

Add missing support for RSPIF when using BlockDevice::get_default_instance().

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team March 5, 2019 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 5, 2019

@marcuschangarm, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

Copy link

@dannybenor dannybenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For which target do you want to define rspif as default?

@marcuschangarm
Copy link
Contributor Author

When compiling the bootloader.

@dannybenor
Copy link

I think this code will better fit the bootloader than a central place. If we will not have the special components in targets.json, it is better to allocate according to the real parallel component. If spif then the bootloader will allocate rspif.

@marcuschangarm
Copy link
Contributor Author

Wouldn't that be an anti-pattern for the user experience, though?

Right now we teach our users to set the default blockdevice using the configurations system. It works for all blockdevices in components, except this one.

@dannybenor
Copy link

Bootloader is not intended to be built by users. They should use a ready made binary

@marcuschangarm
Copy link
Contributor Author

@dannybenor I've sent you a message on Slack.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 78a3d99 into ARMmbed:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants