Add imports of basestring for python 3 #9964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonr
approved these changes
Mar 6, 2019
I'm a release note! 😀 |
theotherjimmy
approved these changes
Mar 6, 2019
|
Heh oops wrong spot, thanks @cmonr 😄 |
0xc0170
approved these changes
Mar 8, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
|
CI job restarted: |
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 16, 2019
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 16, 2019
…tring Add imports of basestring for python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Low priority fix/clean up. Noticed when exporting locally to a zip with Python 3 a traceback occurs about the reference to
basestring. This adds the necessary import, as well to the rest of the tools that also referencedbasestringwithout an import.Pull request type
Reviewers
@cmonr
Release Notes