Skip to content

BLE - Use low power timing primitives #9992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2019
Merged

BLE - Use low power timing primitives #9992

merged 2 commits into from
Mar 17, 2019

Conversation

pan-
Copy link
Member

@pan- pan- commented Mar 7, 2019 •
edited
Loading

Description

Use LowPower timing primitives in BLE API and Cordio port.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@paul-szczepanek-arm

Release Notes

@cmonr
Copy link
Contributor

cmonr commented Mar 7, 2019

Silly question. Have BLE examples been testing with the LPTimer to make sure they still function?

cmonr
cmonr approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem fine.
Am wondering about application performance, since we have no way of measuring runtime regressions.

@pan-
Copy link
Member Author

pan- commented Mar 8, 2019

@desmond-blue You might be interested by this.

0xc0170
0xc0170 approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔋

@desmond-blue
Copy link
Contributor

Excuse me for a question, does this work for platform without lptimer?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2019

CI started

Excuse me for a question, does this work for platform without lptimer?

@pan- Please answer above

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019
Merge pull request ARMmbed#9992 from null
850d485 
null
cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019
Merge pull request ARMmbed#9992 from pan-/ble-use-low-power-ticker
a82d267 
BLE - Use low power timing primitives
@cmonr cmonr merged commit 9ecde42 into ARMmbed:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@paul-szczepanek-arm paul-szczepanek-arm paul-szczepanek-arm approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pan- @cmonr @desmond-blue @0xc0170 @mbed-ci @paul-szczepanek-arm