platform reset API rename #9997

alzix · 2019-03-07T21:17:03Z

Description

Renamed newly added psa_system_reset() API to mbed_system_reset()
We should not use PSA prefix for APIs not defined in PSA specs.

Must be merged after #9910

Targeting RC2

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mikisch81 @orenc17 @mmahadevan108

Release Notes

ciarmcom · 2019-03-07T22:01:08Z

@alzix, thank you for your changes.
@mikisch81 @orenc17 @maclobdell @MarceloSalazar @ARMmbed/mbed-os-core @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-test @ARMmbed/mbed-os-tools please review.

mikisch81 · 2019-03-07T22:41:55Z

components/TARGET_PSA/inc/psa/lifecycle.h

@@ -63,9 +64,11 @@ psa_status_t mbed_psa_reboot_and_request_new_security_state(uint32_t new_state);


 /** \brief Resets the system
- *
+ * 
+ * PSA targets do not allow NPS to access system power domain. 


mikisch81 · 2019-03-07T22:42:32Z

components/TARGET_PSA/inc/psa/lifecycle.h

- *
+ * 
+ * PSA targets do not allow NPS to access system power domain. 
+ * This API requests system reset to be caried out by SPE once all critical secure tasks are finished.


orenc17

please align with psa/errors.h

alzix · 2019-03-07T23:25:52Z

@orenc17, I agree that service should be revisited and adapted to use psa/errors.h. it was written before psa/errors.h was introduced. But as the errors are all internal (the API returns void or actually do not returns at all) it can be post 5.12

alzix · 2019-03-08T00:33:36Z

@orenc17 @mikisch81 please review latest changes.
updated error.h usage
fixed compilation warnings

components/TARGET_PSA/inc/psa/client.h

alzix · 2019-03-08T12:46:08Z

rebased on top #9910

alzix · 2019-03-08T15:56:49Z

A bit context for this PR: this PR renames an API added couple of days ago. It was not part of any release yet and is not expected to effect any external developer.
This API used to implement NVIC Reset on ARMv8-M targets on nonsrcure side.
It is currently used only by NXP port, thus this PR should come after NXP PR is merged as it tweaks the NXP sources. For this very reason @mmahadevan108 is on the CC list

0xc0170 · 2019-03-08T20:26:22Z

It is currently used only by NXP port, thus this PR should come after NXP PR is merged as it tweaks the NXP sources. For this very reason @mmahadevan108 is on the CC list

This needs rebase now, dependency was merged.

alzix · 2019-03-09T07:07:02Z

rebased and squashed

alzix · 2019-03-10T12:46:06Z

fixed astyle

NirSonnenschein · 2019-03-10T13:01:45Z

starting CI

mbed-ci · 2019-03-10T15:17:13Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

alzix · 2019-03-10T16:41:47Z

all green - can we merge it?
please note - if this PR merged before #9996, a minor change in #9996 will be required.

0xc0170 · 2019-03-10T18:13:34Z

please note - if this PR merged before #9996, a minor change in #9996 will be required.

It's merged, all good here?

0xc0170

why mbed_system_reset is not in platform, and accessible to all ? The name leads me to believe this is common API.

orenc17 · 2019-03-10T19:49:55Z

@alzix please rebase and edit TESTS/psa/attestation/main.cpp accordingly

alzix · 2019-03-11T07:22:52Z

@0xc0170

why mbed_system_reset is not in platform, and accessible to all ? The name leads me to believe this is common AP

on ARMv8-M architecture system reset can only be performed from TZ. This API provides an entry point to TZ. We cannot move this API to platform as it is a PSA service and better reside with rest of PSA sources, for the sake of not adding further compilation tweaks

alzix · 2019-03-11T07:24:55Z

Rebased and fixed attestation test.

@NirSonnenschein, can we start CI? We need make sure it will be merged before 5.12 official?

NirSonnenschein · 2019-03-11T07:49:56Z

CI started on latest fixes

0xc0170

Line 57 - todo in lifecycle needs to be removed

I've checked lifecycle - 3 functions, 3 different prefixes

psa_...
mbed_psa...
mbed_...

does each one has special meaning ? why not all mbed_psa or just psa?

add noreturn attributes update lifecycle service to use psa/error.h fix doxygen

alzix · 2019-03-11T08:47:27Z

@0xc0170, solid points on the API names and doxygen

API names - psa_ prefix are for APIs defined in PSA specs. We need these APIs as is for compliance.
mbed_psa APIs are required but are not standardised ant left IMPDEF. We must not use psa_ prefix for these.

0xc0170 · 2019-03-11T09:58:57Z

Restarting CI (earlier run will be aborted)

mbed-ci · 2019-03-11T10:02:14Z

Test run: FAILED

Summary: 2 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test
jenkins-ci/mbed-os-ci_exporter

mbed-ci · 2019-03-11T12:17:59Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 3
Build artifacts

ciarmcom requested review from maclobdell, MarceloSalazar, mikisch81, orenc17 and a team March 7, 2019 22:01

ciarmcom added the needs: review label Mar 7, 2019

ghost added the PM_ACCEPTED label Mar 7, 2019

mikisch81 approved these changes Mar 7, 2019

View reviewed changes

orenc17 suggested changes Mar 7, 2019

View reviewed changes

0xc0170 added release-version: 5.12.0-rc2 needs: preceding PR labels Mar 8, 2019

orenc17 suggested changes Mar 8, 2019

View reviewed changes

components/TARGET_PSA/inc/psa/client.h Show resolved Hide resolved

0xc0170 added needs: work and removed needs: review labels Mar 8, 2019

0xc0170 removed the needs: preceding PR label Mar 8, 2019

NirSonnenschein added needs: review and removed needs: work labels Mar 10, 2019

NirSonnenschein approved these changes Mar 10, 2019

View reviewed changes

orenc17 approved these changes Mar 10, 2019

View reviewed changes

0xc0170 reviewed Mar 10, 2019

View reviewed changes

0xc0170 requested changes Mar 11, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Mar 11, 2019

Rename psa_system_reset to mbed_psa_system_reset

661613c

add noreturn attributes update lifecycle service to use psa/error.h fix doxygen

0xc0170 approved these changes Mar 11, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Mar 11, 2019

0xc0170 removed request for a team March 11, 2019 09:59

0xc0170 added ready for merge and removed needs: CI labels Mar 11, 2019

0xc0170 removed request for a team March 11, 2019 12:30

0xc0170 merged commit 525d463 into ARMmbed:master Mar 11, 2019

0xc0170 removed the ready for merge label Mar 11, 2019

platform reset API rename #9997

platform reset API rename #9997

Uh oh!

Conversation

alzix commented Mar 7, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Mar 7, 2019

Uh oh!

mikisch81 Mar 7, 2019

Choose a reason for hiding this comment

Uh oh!

mikisch81 Mar 7, 2019

Choose a reason for hiding this comment

Uh oh!

orenc17 left a comment

Choose a reason for hiding this comment

Uh oh!

alzix commented Mar 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alzix commented Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

alzix commented Mar 8, 2019

Uh oh!

alzix commented Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Mar 8, 2019

Uh oh!

alzix commented Mar 9, 2019

Uh oh!

alzix commented Mar 10, 2019

Uh oh!

NirSonnenschein commented Mar 10, 2019

Uh oh!

mbed-ci commented Mar 10, 2019

Test run: SUCCESS

Uh oh!

alzix commented Mar 10, 2019

Uh oh!

0xc0170 commented Mar 10, 2019

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

orenc17 commented Mar 10, 2019

Uh oh!

alzix commented Mar 11, 2019

Uh oh!

alzix commented Mar 11, 2019

Uh oh!

NirSonnenschein commented Mar 11, 2019

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

alzix commented Mar 11, 2019

Uh oh!

0xc0170 commented Mar 11, 2019

Uh oh!

mbed-ci commented Mar 11, 2019

Test run: FAILED

Uh oh!

mbed-ci commented Mar 11, 2019

Test run: SUCCESS

Uh oh!

Uh oh!

alzix commented Mar 7, 2019 •

edited

Loading

alzix commented Mar 8, 2019 •

edited

Loading

alzix commented Mar 8, 2019 •

edited

Loading