Add support for custom_targets.json #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalton-arm
force-pushed
the
dev/rwalton-arm/custom-targets-json
branch
2 times, most recently
from
b7e9cbd to
8f803c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 96.54% 96.55% +0.01%
==========================================
Files 94 94
Lines 2605 2615 +10
==========================================
+ Hits 2515 2525 +10
Misses 90 90
|
rwalton-arm
force-pushed
the
dev/rwalton-arm/custom-targets-json
branch
2 times, most recently
from
60af69f to
6c19600
Compare
2 tasks
2 tasks
rwalton-arm
force-pushed
the
dev/rwalton-arm/custom-targets-json
branch
3 times, most recently
from
3d4d11e to
30735ba
Compare
rwalton-arm
force-pushed
the
dev/rwalton-arm/custom-targets-json
branch
from
697a245 to
3f2f8b6
Compare
rwalton-arm
changed the title
rwalton-arm
changed the title
Patater
reviewed
Feb 2, 2021
urutva
force-pushed
the
dev/rwalton-arm/custom-targets-json
branch
3 times, most recently
from
ac914f2 to
bf10d32
Compare
Patater
suggested changes
Feb 5, 2021
| @@ -0,0 +1,18 @@ | |||
| ## | |||
There was a problem hiding this comment.
Please make this header match the format used in src/mbed_tools/project/_internal/templates/CMakeLists.tmpl (single #, no extra lines)
There was a problem hiding this comment.
Thanks for providing a fix for this @Patater
The default style for licenseheaders for CMake is to use ## and to have some extra start and end comments around the license. Mbed style is to use single # and no extra start and end comments. Add a settings file for licenseheaders to override the default style with Mbed style.
The CMake function `mbed_set_mbed_target_linker_script` is deprecated in Mbed OS. Remove it from `CMakeLists.tmpl`.
urutva
force-pushed
the
dev/rwalton-arm/custom-targets-json
branch
from
bf10d32 to
94d85af
Compare
Patater
reviewed
Feb 5, 2021
|
Is there a guide for using this feature? I am getting |
|
To answer my own question: The custom board porting guide has been updated to incorporate CLI 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for custom_targets.json in the tools.
This is dependent on mbed-os CMake changes.
Without those changes adding a custom target using
add_subdirectorywill make mbed-os fail to build for standard mbed targets.With those changes (once applied to all targets) you can add your target using
add_subdirectory(<target-dir> EXCLUDE_FROM_ALL)before adding the mbed-os subdirectory, in the top level CMakeLists.txt, and the custom target will integrate into the build system without breaking it.While I'm here fix the
deploy --forceoption as that was broken.Test Coverage