Skip to content

config: move mbed config cmake mbed_config.cmake file from root to build directory #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2021
Merged

config: move mbed config cmake mbed_config.cmake file from root to build directory #189

merged 4 commits into from
Feb 15, 2021

Conversation

urutva
Copy link
Contributor

@urutva urutva commented Feb 12, 2021

Description

The MbedProgramFiles contains list of files related to an Mbed program. When a new Mbed program gets created then MbedProgramFiles is instantiated. However, location of mbed config cmake file mbed_config.cmake is not known at this stage. Therefore, move mbed_config.cmake to config component where it'll be first used.

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

@codecov
Copy link

codecov bot commented Feb 12, 2021 •
edited
Loading

Codecov Report

Merging #189 (4ff5453) into master (73d9003) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   96.56%   96.56%   -0.01%     
==========================================
  Files          94       94              
  Lines        2619     2617       -2     
==========================================
- Hits         2529     2527       -2     
  Misses         90       90
Impacted Files Coverage Δ
src/mbed_tools/cli/build.py 100.00% <ø> (ø)
src/mbed_tools/cli/configure.py 100.00% <ø> (ø)
src/mbed_tools/project/_internal/project_data.py 97.18% <ø> (-0.12%) ⬇️
src/mbed_tools/build/config.py 100.00% <100.00%> (ø)

@Patater Patater self-requested a review February 12, 2021 15:20
Patater
Patater reviewed Feb 12, 2021
View reviewed changes
@urutva urutva force-pushed the move-mbed-config-cmake branch from 6fa1f32 to 13d3bdf Compare February 12, 2021 16:00
@urutva
build: Update docstring
0ed18dc 
Remove comments not valid anymore from docstring.
@urutva
config: Move mbed config cmake file
3a3c598 
The `MbedProgramFiles` contains list of files related to an Mbed
program. When a new Mbed program gets created then `MbedProgramFiles` is
instantiated. However, location of mbed config cmake file
`mbed_config.cmake` is not known at this stage. Therefore, move
`mbed_config.cmake` to config component where it'll be first used.
@urutva
app: Update app CMakeLists.txt template
1dea6f6 
The location of Mbed config cmake file `mbed_config.cmake` is moved from
root to build directory. App CMakeLists.txt template is updated to
reflect the same.
@urutva urutva force-pushed the move-mbed-config-cmake branch from 76c08cf to 8f9efd5 Compare February 15, 2021 12:16
urutva added a commit to urutva/mbed-os-example-blinky that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
40b371a 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-blinky-baremetal that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
eead053 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-tls that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
4096fc2 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-ble that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
97dfa9b 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-sockets that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
e954f6e 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-cellular that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
d5292e3 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-lorawan that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
6a7454c 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-devicekey that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
412123e 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-thread-statistics that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
e4f2011 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-sys-info that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
28f9858 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-cpu-stats that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
0535cef 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-error-handling that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
0b3e4e0 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-filesystem that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
4132a25 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-mesh-minimal that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
db4c30c 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-mbed-crypto that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
c42a409 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-nfc that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
b8699ea 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-blockdevice that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
85440d4 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-kvstore that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
d6784e0 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-crash-reporting that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
eed1921 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-sd-driver that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
5d6894b 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
urutva added a commit to urutva/mbed-os-example-attestation that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file
3140b3c 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva urutva mentioned this pull request Feb 15, 2021
Merged
Patater
Patater approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xc0170 pushed a commit to ARMmbed/mbed-os-example-devicekey that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file (#68)
0fb9be3 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
0xc0170 pushed a commit to ARMmbed/mbed-os-example-sockets that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file (#181)
182221b 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
0xc0170 pushed a commit to ARMmbed/mbed-os-example-blinky that referenced this pull request Feb 15, 2021
@urutva
Update location of Mbed OS cmake config file (#257)
28c0855 
Mbed OS tools now generates Mbed OS cmake config file in build folder
instead of root folder (ARMmbed/mbed-tools#189).
Update `CMakeLists.txt` to use build folder to locate Mbed OS cmake
config file.
@urutva
travis: fix custom target support
4ff5453 
The mbed-os commit
ARMmbed/mbed-os@39ab9c8
updated the naming conventions of mbed targets. Travis test data is
updated to match the new naming convention.
@urutva urutva force-pushed the move-mbed-config-cmake branch from 8f9efd5 to 4ff5453 Compare February 15, 2021 16:33
@urutva urutva merged commit 30eace6 into ARMmbed:master Feb 15, 2021
@urutva urutva deleted the move-mbed-config-cmake branch February 15, 2021 17:07
@rajkan01 rajkan01 mentioned this pull request Feb 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urutva @Patater