Avoid type collision by renaming callback variable #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build error "arm_hal_timer.cpp:50:5: error: reference to 'callback' is ambiguous". Fix the build error by renaming callback to arm_hal_callback to avoid collision with callback defined in ./mbed-os/hal/api/Callback.h
|
@kjbracey-arm , @mikter would you please review? |
|
I'd say that having "mbed.h" add "callback" to the global namespace is the primary sin here. We won't be the only component broken by that. And fixing it here for mbed-os requires actually an extra step over changing mbed-os. This is fine as-is though. See how to actually get it in... |
|
Actually, this repository may as well be retired - make it straight to mbed-os. |
|
Created this PR to mbed-os: ARMmbed/mbed-os#2688 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build error "arm_hal_timer.cpp:50:5: error: reference to 'callback'
is ambiguous".
Fix the build error by renaming callback to arm_hal_callback to
avoid collision with callback defined in ./mbed-os/hal/api/Callback.h