Makefile: Build uVisor for M3, even on M4s #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessandroA
suggested changes
Apr 7, 2017
Makefile
Outdated
| @@ -140,7 +140,7 @@ ifeq ("$(PROGRAM_VERSION)","") | |||
| PROGRAM_VERSION:='unknown' | |||
| endif | |||
|
|
|||
| FLAGS_CM4:=-mcpu=cortex-m4 -march=armv7e-m -mthumb | |||
| FLAGS_CM4:=-mcpu=cortex-m3 -march=armv7-m -mthumb | |||
There was a problem hiding this comment.
Could you rename FLAGS_CM4 to FLAGS_CORE? Other than that, LGTM.
Currently, uVisor builds with `-mcpu=cortex-m4`, even on Cortex M3 CPUs. This can lead to using unavailable instructions. Build uVisor using the least common denominator architecture. This avoids using unavailable instructions when targeting Cortex M3 CPUs.
AlessandroA
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, uVisor builds with
-mcpu=cortex-m4, even on Cortex M3 CPUs.This can lead to using unavailable instructions. Build uVisor using the
least common denominator architecture. This avoids using unavailable
instructions when targeting Cortex M3 CPUs.
@AlessandroA @niklas-arm