V2A RCM PowerShell changes #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imshashwataggarwal
requested review from
ayfathim,
anmolbhatia289,
shrauta-ms,
vidyadharijami and
nilgupta6
imshashwataggarwal
force-pushed
the
v2arcm2102
branch
from
c9780e6 to
cbf46d1
Compare
| @@ -217,6 +228,7 @@ public class NewAzureRmRecoveryServicesAsrPolicy : SiteRecoveryCmdletBase | |||
| [Parameter(DontShow = true, ParameterSetName = ASRParameterSets.VMwareToAzure)] | |||
| [Parameter(DontShow = true, ParameterSetName = ASRParameterSets.AzureToVMware)] | |||
| [Parameter(DontShow = true, ParameterSetName = ASRParameterSets.AzureToAzure)] | |||
| [Parameter(DontShow = true, ParameterSetName = ASRParameterSets.ReplicateVMwareToAzure)] | |||
There was a problem hiding this comment.
Can you think of some other name like VmwareToAzureUsingRcm.
| Mandatory = false, | ||
| HelpMessage = "Specifies the disk configuration to be used for VMware to Azure using RCM disaster recovery scenario.")] | ||
| [ValidateNotNullOrEmpty] | ||
| public ASRInMageRcmDiskInput[] InMageRcmDiskRelicationConfig { get; set; } |
There was a problem hiding this comment.
NIT: InMageRcmDiskRelicationConfig -> InMageRcmDiskReplicationConfig
nilgupta6
force-pushed
the
newApiVersion/asr2021-02-10
branch
2 times, most recently
from
2019398 to
0a05b20
Compare
imshashwataggarwal
force-pushed
the
v2arcm2102
branch
from
cbf46d1 to
8877808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.