Skip to content

Commit 1ae58d4

Browse files
ext/bcmath: Removed unnecessary zero padding (php#14134)
bc_num is initialized to 0 by `memset`, so there is no need to write it to 0.
1 parent a728e54 commit 1ae58d4

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

ext/bcmath/libbcmath/src/doaddsub.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,6 @@ bc_num _bc_do_add(bc_num n1, bc_num n2, size_t scale_min)
5151
sum_digits = MAX (n1->n_len, n2->n_len) + 1;
5252
sum = bc_new_num (sum_digits, MAX(sum_scale, scale_min));
5353

54-
/* Zero extra digits made by scale_min. */
55-
if (scale_min > sum_scale) {
56-
sumptr = (char *) (sum->n_value + sum_scale + sum_digits);
57-
for (int count = scale_min - sum_scale; count > 0; count--) {
58-
*sumptr++ = 0;
59-
}
60-
}
61-
6254
/* Start with the fraction part. Initialize the pointers. */
6355
n1bytes = n1->n_scale;
6456
n2bytes = n2->n_scale;
@@ -145,14 +137,6 @@ bc_num _bc_do_sub(bc_num n1, bc_num n2, size_t scale_min)
145137
min_scale = MIN(n1->n_scale, n2->n_scale);
146138
diff = bc_new_num (diff_len, MAX(diff_scale, scale_min));
147139

148-
/* Zero extra digits made by scale_min. */
149-
if (scale_min > diff_scale) {
150-
diffptr = (char *) (diff->n_value + diff_len + diff_scale);
151-
for (count = scale_min - diff_scale; count > 0; count--) {
152-
*diffptr++ = 0;
153-
}
154-
}
155-
156140
/* Initialize the subtract. */
157141
n1ptr = (char *) (n1->n_value + n1->n_len + n1->n_scale - 1);
158142
n2ptr = (char *) (n2->n_value + n2->n_len + n2->n_scale - 1);

0 commit comments

Comments
 (0)