Skip to content

ext/bcmath: Removed unnecessary zero padding #14134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2024
Merged

ext/bcmath: Removed unnecessary zero padding #14134

merged 1 commit into from
May 4, 2024

Conversation

SakiTakamachi
Copy link
Member

bc_num is initialized to 0 by memset, so there is no need to write it to 0.

@SakiTakamachi SakiTakamachi requested a review from Girgias as a code owner May 4, 2024 14:18
nielsdos
nielsdos approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clearly correct, I actually had found the same optimization too. I'll rebase my PR after you merged this.

@SakiTakamachi
Copy link
Member Author

Thanks, I will merge this, as soon as CI passes.

@SakiTakamachi SakiTakamachi merged commit 1ae58d4 into php:master May 4, 2024
@SakiTakamachi SakiTakamachi deleted the bcmath_addsub_remove_zero_pad branch May 4, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@Girgias Girgias Awaiting requested review from Girgias Girgias is a code owner

Assignees
No one assigned
Labels
Extension: bcmath
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SakiTakamachi @nielsdos