Update sample to follow Basher and Zero Trust #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

derisen merged 19 commits into main from basher-1-2-b2c

Dec 7, 2022

Contributor

salman90 commented Dec 1, 2022

Pull Request

Purpose

Update sample to follow Basher and Zero Trust

Does this introduce a breaking change

    [ x ] Yes
    [ ] No

Pull request type

What kind of change does this Pull Request introduce?

    [ ] Bugfix
    [ x ] Feature
    [ x ] Code style update (formatting, local variables)
    [ x ] Documentation content changes
    [ ] Other... Please describe:

How to test

Get the code

    git clone [repo-address]
    cd [repo-name]
    git checkout [branch-name]
    npm install

Test the code

What to check

ex: verify that the following are valid:

...

Other Information


          update sample to follow basher and zero trust

e2a4019

salman90 requested review from derisen, kalyankrishna1 and v-michaelmi

December 1, 2022 16:30


          update tests

e2c979a

salman90 requested review from aremo-ms and tonyYuhaoYangMcrS

December 1, 2022 16:34

github-advanced-security bot found potential problems

View reviewed changes

1-Authentication/2-sign-in-b2c/server.js Fixed Show fixed Hide fixed

salman90 added 6 commits

December 1, 2022 08:55


          add rate limit to server

4e00a17


          update table style

dc7ad9d


          update readme

023d953


          minor edit

88bc9cd


          update table style

809f063


          update readme

90df3a0

derisen reviewed

View reviewed changes

1-Authentication/2-sign-in-b2c/AppCreationScripts/sample.json Outdated Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/2-sign-in-b2c/App/index.html Outdated Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/2-sign-in-b2c/App/authPopup.js Outdated Show resolved Hide resolved

kalyankrishna1 reviewed

View reviewed changes

1-Authentication/2-sign-in-b2c/README.md Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/2-sign-in-b2c/server.js Outdated Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/2-sign-in-b2c/App/authPopup.js Outdated Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/2-sign-in-b2c/README.md Outdated Show resolved Hide resolved

derisen reviewed

View reviewed changes

1-Authentication/2-sign-in-b2c/README.md Show resolved Hide resolved

kalyankrishna1 reviewed

View reviewed changes

1-Authentication/2-sign-in-b2c/README.md Show resolved Hide resolved

Contributor

kalyankrishna1 commented Dec 5, 2022

sign-in with gitHub creates a "Authorize derisen" popup..

kalyankrishna1 approved these changes

View reviewed changes

Contributor

kalyankrishna1 left a comment

Kalyan Krishna and others added 5 commits

December 5, 2022 12:42


          minor edit

c94d4b0


          Update 1-Authentication/2-sign-in-b2c/AppCreationScripts/sample.json

629fedd

Update redirect uri

Co-authored-by: Doğan Erişen <[email protected]>


          Update 1-Authentication/2-sign-in-b2c/App/index.html

ecd0916

navbar update

Co-authored-by: Doğan Erişen <[email protected]>


          Update 1-Authentication/2-sign-in-b2c/README.md

dd0f045

Update readme

Co-authored-by: Doğan Erişen <[email protected]>


          respond to comments

6a94f73

salman90 added 2 commits

December 6, 2022 17:33


          update packages

1ca9f2a


          update packages in other samples

51cf9f8

salman90 requested a review from derisen

December 7, 2022 01:43

salman90 and others added 4 commits

December 6, 2022 17:51


          update chapter 2

66a6d2e


          update ap

ceb1272


          minor update

6ae9543


          minor review changes

097deff

derisen approved these changes

View reviewed changes

derisen merged commit 7a1ac45 into main

derisen deleted the basher-1-2-b2c branch

December 7, 2022 22:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kalyankrishna1 kalyankrishna1 approved these changes

derisen derisen approved these changes

v-michaelmi Awaiting requested review from v-michaelmi

aremo-ms Awaiting requested review from aremo-ms

tonyYuhaoYangMcrS Awaiting requested review from tonyYuhaoYangMcrS

Labels

None yet