Skip to content

Update sample call graph API to follow Basher and Zero Trust #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 7, 2022

Conversation

salman90
Copy link
Contributor

@salman90 salman90 commented Dec 2, 2022

Pull Request

Purpose

  • Update sample call graph API to follow Basher and Zero Trust.

Does this introduce a breaking change

    [ x ] Yes
    [ ] No

Pull request type

What kind of change does this Pull Request introduce?

    [ ] Bugfix
    [ x ] Feature
    [ x ] Code style update (formatting, local variables)
    [ x ] Documentation content changes
    [ ] Other... Please describe:

How to test

  • Get the code
    git clone [repo-address]
    cd [repo-name]
    git checkout [branch-name]
    npm install
  • Test the code

What to check

ex: verify that the following are valid:

  • ...

Other Information

@kalyankrishna1
Copy link
Contributor

      scopes: [ "Mail.Read" ]

Contacts.Read?


Refers to: 2-Authorization-I/1-call-graph/README.md:221 in d5271fa. [](commit_id = d5271fa, deletion_comment = False)

Copy link
Contributor

@kalyankrishna1 kalyankrishna1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

}

async function addAnotherAccount(event) {
if (event.target.innerHTML.includes("@")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this check needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check the if the clicked list item is an email. I will keep this.

@salman90
Copy link
Contributor Author

salman90 commented Dec 7, 2022

      scopes: [ "Mail.Read" ]

Contacts.Read?

Refers to: 2-Authorization-I/1-call-graph/README.md:221 in d5271fa. [](commit_id = d5271fa, deletion_comment = False)

Done

Comment on lines +17 to +19
app.get('/redirect', (req, res) => {
res.sendFile(path.join(__dirname + '/App/redirect.html'));
});

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [a file system access](1), but is not rate-limited.
@salman90 salman90 requested a review from derisen December 7, 2022 19:01
@derisen derisen merged commit 8ba6be8 into main Dec 7, 2022
@derisen derisen deleted the basher-2-1 branch December 7, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants