Migration -All support code-review fixes

Author: arramach

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/ConfirmAzureStorSimpleLegacyVolumeContainerStatus.cs

@@ -26,9 +26,6 @@ namespace Microsoft.WindowsAzure.Commands.StorSimple.Cmdlets
     [Cmdlet(VerbsLifecycle.Confirm, "AzureStorSimpleLegacyVolumeContainerStatus")]
     public class ConfirmAzureStorSimpleLegacyVolumeContainerStatus : StorSimpleCmdletBase
     {
-        public const string AllContainers = "ALL";
-        public const string SpecificContainers = "DCSpecific";
-
         [Parameter(Mandatory = true, Position = 0, HelpMessage = StorSimpleCmdletHelpMessage.MigrationConfigId)]
         [ValidateNotNullOrEmpty]
         public string LegacyConfigId { get; set; }
@@ -37,11 +34,11 @@ public class ConfirmAzureStorSimpleLegacyVolumeContainerStatus : StorSimpleCmdle
         [ValidateSet("Commit", "Rollback", IgnoreCase = true)]
         public string MigrationOperation { get; set; }
 
-        [Parameter(Mandatory = true, Position = 2, ParameterSetName = SpecificContainers,
+        [Parameter(Mandatory = true, Position = 2, ParameterSetName = StorSimpleCmdletParameterSet.MigrateSpecificContainer,
             HelpMessage = StorSimpleCmdletHelpMessage.MigrationLegacyDataContainers)]
         public string[] LegacyContainerNames { get; set; }
 
-        [Parameter(Mandatory = true, Position = 2, ParameterSetName = AllContainers,
+        [Parameter(Mandatory = true, Position = 2, ParameterSetName = StorSimpleCmdletParameterSet.MigrateAllContainer,
             HelpMessage = StorSimpleCmdletHelpMessage.MigrationAllContainers)]
         public SwitchParameter All { get; set; }
 

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/ImportAzureStorSimpleLegacyVolumeContainer.cs

@@ -25,18 +25,15 @@ namespace Microsoft.WindowsAzure.Commands.StorSimple.Cmdlets
     [Cmdlet(VerbsData.Import, "AzureStorSimpleLegacyVolumeContainer")]
     public class ImportAzureStorSimpleLegacyVolumeContainer : StorSimpleCmdletBase
     {
-        public const string AllContainers = "ALL";
-        public const string SpecificContainers = "DCSpecific";
-
         [Parameter(Mandatory = true, Position = 0, HelpMessage = StorSimpleCmdletHelpMessage.MigrationConfigId)]
         [ValidateNotNullOrEmpty]
         public string LegacyConfigId { get; set; }
 
-        [Parameter(Mandatory = true, Position = 1, ParameterSetName = SpecificContainers,
+        [Parameter(Mandatory = true, Position = 1, ParameterSetName = StorSimpleCmdletParameterSet.MigrateSpecificContainer,
             HelpMessage = StorSimpleCmdletHelpMessage.MigrationLegacyDataContainers)]
         public string[] LegacyContainerNames { get; set; }
 
-        [Parameter(Mandatory = true, Position = 1, ParameterSetName = AllContainers,
+        [Parameter(Mandatory = true, Position = 1, ParameterSetName = StorSimpleCmdletParameterSet.MigrateAllContainer,
             HelpMessage = StorSimpleCmdletHelpMessage.MigrationAllContainers)]
         public SwitchParameter All { get; set; }        
 

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/StartAzureStorSimpleLegacyVolumeContainerMigrationPlan.cs

@@ -25,18 +25,15 @@ namespace Microsoft.WindowsAzure.Commands.StorSimple.Cmdlets
     [Cmdlet(VerbsLifecycle.Start, "AzureStorSimpleLegacyVolumeContainerMigrationPlan")]
     public class StartAzureStorSimpleLegacyVolumeContainerMigrationPlan : StorSimpleCmdletBase
     {
-        public const string AllContainers = "ALL";
-        public const string SpecificContainers = "DCSpecific";
-
         [Parameter(Mandatory = true, Position = 0, HelpMessage = StorSimpleCmdletHelpMessage.MigrationConfigId)]
         [ValidateNotNullOrEmpty]
         public string LegacyConfigId { get; set; }
 
-        [Parameter(Mandatory = true, Position = 1, ParameterSetName = SpecificContainers,
+        [Parameter(Mandatory = true, Position = 1, ParameterSetName = StorSimpleCmdletParameterSet.MigrateSpecificContainer,
             HelpMessage = StorSimpleCmdletHelpMessage.MigrationLegacyDataContainers)]
         public string[] LegacyContainerNames { get; set; }
 
-        [Parameter(Mandatory = true, Position = 1, ParameterSetName = AllContainers,
+        [Parameter(Mandatory = true, Position = 1, ParameterSetName = StorSimpleCmdletParameterSet.MigrateAllContainer,
             HelpMessage = StorSimpleCmdletHelpMessage.MigrationAllContainers)]
         public SwitchParameter All { get; set; }
 

src/ServiceManagement/StorSimple/Commands.StorSimple/StorSimpleCmdletParameterSet.cs

@@ -28,5 +28,7 @@ internal static class StorSimpleCmdletParameterSet
         public const string IdentifyByStatus = "IdentifyByStatus";
         public const string UseExistingStorageAccount = "UseExistingStorageAccount";
         public const string CreateNewStorageAccount = "CreateNewStorageAccount";
+        public const string MigrateAllContainer = "MigrateAllContainer";
+        public const string MigrateSpecificContainer = "MigrateSpecificContainer";
     }
 }