Migration -All support . Code review changes

Author: arramach

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/ConfirmAzureStorSimpleLegacyVolumeContainerStatus.cs

@@ -49,15 +49,26 @@ public override void ExecuteCmdlet()
                 var confirmMigrationRequest = new MigrationConfirmStatusRequest();
                 confirmMigrationRequest.Operation =
                     (MigrationOperation) Enum.Parse(typeof (MigrationOperation), MigrationOperation, true);
-                if (All.IsPresent)
+                switch (ParameterSetName)
                 {
-                    confirmMigrationRequest.DataContainerNameList = new List<string>();
-                }
-                else
-                {
-                    confirmMigrationRequest.DataContainerNameList =
-                            new List<string>(LegacyContainerNames.ToList().Distinct(
-                                StringComparer.InvariantCultureIgnoreCase));
+                    case StorSimpleCmdletParameterSet.MigrateAllContainer:
+                        {
+                            confirmMigrationRequest.DataContainerNameList = new List<string>();
+                            break;
+                        }
+                    case StorSimpleCmdletParameterSet.MigrateSpecificContainer:
+                        {
+                           confirmMigrationRequest.DataContainerNameList =
+                           new List<string>(LegacyContainerNames.ToList().Distinct(
+                               StringComparer.InvariantCultureIgnoreCase));
+                            break;
+                        }
+                    default:
+                        {
+                            // unexpected code path hit.
+                            throw new ParameterBindingException(
+                                string.Format(Resources.MigrationParameterSetNotFound, ParameterSetName));
+                        }
                 }
 
                 var status = StorSimpleClient.ConfirmLegacyVolumeContainerStatus(LegacyConfigId, confirmMigrationRequest);

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/ImportAzureStorSimpleLegacyVolumeContainer.cs

@@ -49,15 +49,26 @@ public override void ExecuteCmdlet()
             try
             {
                 var importDataContainerRequest = new MigrationImportDataContainerRequest();
-                if(All.IsPresent)
+                switch (ParameterSetName)
                 {
-                    importDataContainerRequest.DataContainerNames = new List<string>();
-                }
-                else
-                {
-                    importDataContainerRequest.DataContainerNames =
-                            new List<string>(LegacyContainerNames.ToList().Distinct(
-                                StringComparer.InvariantCultureIgnoreCase));
+                    case StorSimpleCmdletParameterSet.MigrateAllContainer:
+                        {
+                            importDataContainerRequest.DataContainerNames = new List<string>();
+                            break;
+                        }
+                    case StorSimpleCmdletParameterSet.MigrateSpecificContainer:
+                        {
+                            importDataContainerRequest.DataContainerNames =
+                                    new List<string>(LegacyContainerNames.ToList().Distinct(
+                                        StringComparer.InvariantCultureIgnoreCase));
+                            break;
+                        }
+                    default:
+                        {
+                            // unexpected code path.
+                            throw new ParameterBindingException(
+                                string.Format(Resources.MigrationParameterSetNotFound, ParameterSetName));
+                        }
                 }
 
                 importDataContainerRequest.ForceOnOtherDevice = Force.IsPresent;

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/StartAzureStorSimpleLegacyVolumeContainerMigrationPlan.cs

@@ -43,15 +43,26 @@ public override void ExecuteCmdlet()
             {
                 var startMigrationPlanRequest = new MigrationPlanStartRequest();
                 startMigrationPlanRequest.ConfigId = LegacyConfigId;
-                if (All.IsPresent)
+                switch (ParameterSetName)
                 {
-                    startMigrationPlanRequest.DataContainerNameList = new List<string>();
-                }
-                else
-                {
-                    startMigrationPlanRequest.DataContainerNameList =
+                    case StorSimpleCmdletParameterSet.MigrateAllContainer:
+                        {
+                            startMigrationPlanRequest.DataContainerNameList = new List<string>();
+                            break;
+                        }
+                    case StorSimpleCmdletParameterSet.MigrateSpecificContainer:
+                        {
+                            startMigrationPlanRequest.DataContainerNameList =
                             new List<string>(LegacyContainerNames.ToList().Distinct(
                                 StringComparer.InvariantCultureIgnoreCase));
+                            break;
+                        }
+                    default:
+                        {
+                            // unexpected code path hit.
+                            throw new ParameterBindingException(
+                                string.Format(Resources.MigrationParameterSetNotFound, ParameterSetName));
+                        }
                 }
 
                 var status = StorSimpleClient.StartLegacyVolumeContainerMigrationPlan(startMigrationPlanRequest);

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs

@@ -571,4 +571,7 @@ a special character</value>
   <data name="MigrationPlanNotFound" xml:space="preserve">
     <value>No migration plan found corresponding to the LegacyConfigId.</value>
   </data>
+  <data name="MigrationParameterSetNotFound" xml:space="preserve">
+    <value>Parameter set cannot be resolved using the specified named parameters {0}</value>
+  </data>
 </root>