Add Variety to Az.Predictor (#13480)

* psd1 & psm1 of Az.Installer with a demo cmdlet (#12698)

* Internal/az.installer (#12817)

* add util functions

* add install-azmodule

* add log to cmdlets

* move verbose messages to debug

* move under tools\

* polish warning message

* move install-azmodule to exports

* export install-azmodule

* rename to az.tools.installer

* Internal/az.installer (#12860)

* add util functions

* add install-azmodule

* add log to cmdlets

* move verbose messages to debug

* move under tools\

* polish warning message

* move install-azmodule to exports

* export install-azmodule

* rename to az.tools.installer

* add uninstall-AzModule

* Cmdlet Update-AzModule (#12832)

* Update-AzModule

* Address to PM requirements

1. Remove prefix Az. when input module name
2. update calculate from most recently installed respositories of
different modules
3. reorder the sequence of module udpate and uninstall
4. other bug fix

* Add telemetry

* Support telemetry

* Move Get-AzModuleUpdateList to internal (#12865)

* add telemetry to Uninstall-AzModule cmdlet

* bugfix: module name was not handled properly

* Add environment variable to disable telemetry

* parallel executing Install/Uninstall module

* update code after review

* improve performance

* Fix Update-AzModule issues

* bug fix

* remove unused util

* remove az.accounts when allow preview

* Fix issue when no module to udpate

* Add sign pipeline

* skip confirmation when remove-job

* remove debug info

* fix parameter reference

* Initial checking in AzPredictor (#12847)

- It contains an implementation of ICommandPredictor that provides
  predictions to PSReadLine.
- It also talks to the service endpoints to get the predictions.
- It reads from the profile settings about the service endpoint.
- There are some tests cases.

* filter installedmodules before uninstall

* bugfix for uninstall

* Add synopsis and example to exported cmdlets

* add default parameter set for uninstall-azmodule

* add input validatin

* remove unnecessary warning message

* Build and package module under artifacts folder

* Improve Az.Tool.Predictor (#12922)

* Set up the dependencies on the PSReadline 2.1.0

* Initialize the env when the module is imported.

- Add a script AzPredictor.ps1 to set the psreadline prediction view and
  source.
- The script is run when the module is imported.

* Fix a bug when loading settings from user profile.

- The settings from user profile may not exist. In this case we should
  just ignore it and use the default one.

* Fix issues in getting settings and send requests.

- Fix the way to get the Azure PowerShell settings regarding collecting
  telemetry.
- Avoid sending multiple requests while there is one running.

* Use the NuGet pacakges from nuget.org.

- Remove the local feed for those NuGet packages.

* Rename namespace/assemblies/module name

* Collect telemetry where we get the prediction.

* Make some classes internal.

* Add dependencies on Az module

- This avoid the issue that our module loads
  Microsoft.Azure.PowerShell.Common dlls and Az tries to load it too.

* Remove ps1 file that sets psreadline options.

- We should instruct the users to set the options by themselves.

* Remove psreadline module since it's not released.

* Fix the merge issue

* Add Az as external dependency

* Add pipeline 'sign-tool-predictor'

* Update sign-tool-predictor.yml for Azure Pipelines

* Update sign-tool-predictor.yml for Azure Pipelines

* net.webclient.downloadfile

* refine command

* clean build

* Update sign-tool-predictor.yml for Azure Pipelines

* Improve the build of Az.Tools.Predictor (#12974)

* Change the build for Az.Tools.Predictor

 - Do a 'dotnet publish' instead of 'dotnet build' when the
   configuration is release.
- When the configuration is release, replace the output folder with the
  ones from publish folder. The output folder is where the package
  retrieve the contents from. This will have the module and all the
  dependencies in the package.
- The package target only runs when the configuration is release.
- Add a target Test to run the unit tests.
- Update the build command in azure pipeline to build with configuration
  release.

* Specify the sub-folder artifact for each tool.

- The build process involves deleting the artifact folders. And each
  tool shares the same artifact folder. This may be an issue if we build
  them in parralel because the build process of a tool will delete the
  folder while another tool is being built.
- We'll use sub-folder for each tool in the artifact folder.

Co-authored-by: Beisi Zhou <[email protected]>

* Update sign-tool-predictor.yml for Azure Pipelines

* Update sign-tool-predictor.yml for Azure Pipelines

* Update sign-tool-predictor.yml for Azure Pipelines

* Update sign-tool-predictor.yml for Azure Pipelines

* Override powershellcorecommandPrefix

* join_path

* Update sign-tool-predictor.yml for Azure Pipelines

* Update sign-tool-predictor.yml for Azure Pipelines

* Update sign-tool-predictor.yml for Azure Pipelines

* Update sign-tool-predictor.yml for Azure Pipelines

* Install Az

* Update sign-tool-predictor.yml for Azure Pipelines

* Update sign-tool-predictor.yml for Azure Pipelines

* Sign dll

* Remove dll sign

* Predict parameter values in the suggestion (#12984)

* Get the parameter value from the history.

* Add a mock ps console for testing purpose.

- The mock ps console will echo back most of the commands. So that we
  don't need to really execute the Az command on Azure to test the
  prediction.

* improve telemetry (#13025)

* Correlate the telemetry event we send.

- We have these telemetry entry points when we provide suggestion, when
  a suggestion is accepted, and when the user executes some command. We
  add a SuggestionId to the telemetry events so that we can correlate
  those three events. Doing that we know what suggestions are provided,
  accepted, and executed.

* Collect and correlate our telemetry event.

- With this change, we have these telemetry events;
  * RequestPrediction
  * GetSuggestion
  * AcceptSuggestion
  * CommandHistory
- The events can be correlated by the session id and correlate id that
  are associate with the events.

* Fix the request body.

* Rename the prediction source.

* Collect telemetry when an error occurs.

* Remove some PII field

* Collect user input in GetSuggestion event.

* Use a common telemetry event prefix.

* Remove the .gitignore that shouldn't be added.

* Clean up the code.

* return multiple suggestion (#13098)

* Return multiple suggestions.

- Add a setting to configure at most how many suggestions to return.
- We'll go through the command/parameters one by one and to construct
  the suggestion. We may return multiple suggestions for the same
  command but with different parameter sets;

* Use camel casing in the setting fields.

- Looks like other json file in $HOME/.azure use camel case or
  PascalCase. None use snake case.

* Fix a logic error.

- We'll use the command list for suggestion while the prediction list
  isn't available.

* Stop finding suggestion when the count is met.

* Improve the MockPSConsole.

* Cache the last two commands from the history.

* Reduce the dependencies on Azure powershell common. (#13113)

- That assembly and its dependencies causes a conflict if we load this module
  and Az.Accounts module. Though we can work around by sepcifying Az as a
  dependencies on this module, that'll cause long loading time.
- The reason of loading that assembly is to get the setting about Azure
  PowerShell data collection. We can copy part of the code to load that
  file, so that we don't need that assembly as the dependency.

* Add a missing file. (#13234)

* Fix duplicate text (#13326)

* Improve the debugging experience.

- GetSuggestion gets cancelled during debugging because it times out. So
  we use an environment variable to control whether to allow
cancellation from psreadline.
- Use another macro to control if print message for telemetry.

* Fix a bug that the command line is repeated in the suggestion.

- When we parse the command line and there is an incomplete parameter
  list, we repeat the command line in the suggestion.
- The cause is that we parse the command line and get the wrong
  parameter set from the user input

* Update how we send request and collect telemetry (#13327)

* Fix the query

* Reduce the number of requests to the service.

- We request the prediction for the command history. When the command
  history isn't changed, we don't need to request the prediction again.

* Not to collect the parameter value in the telemetry.

* add variety to predictions list

* add variety to predictions list

* Bug fixes and performance improvement (#13410)

* Reduce extra cost to the perf issue.

* Remove the aggregation on the parameter set.

* Fix an issue

* Fix some comments.

* Improve the telemetry and http request (#13354)

* Collect user id and mac address.

- We hash the user account id and the mac address, and collect those in
  the telemetry. These are used to find how many users are using this
  mdoule.
- We also send the hashed user account id in the http request header.
  This is used to enable throttling by user account.

* Rename

* Collect more data for diagnostic purpose.

* Fix typo

* Remove getting Az modules versions.

* Fixed issue of duplicate threshold consistency caused by two Query function calls as well as duplicate tolerance when list of novel commands is insufficiently small

* Fixed issue of duplicate threshold consistency caused by two Query function calls as well as duplicate tolerance when list of novel commands is insufficiently small

* remove commented lines, change Dictionary to IDictionary

Co-authored-by: Jin Lei <[email protected]>
Co-authored-by: Yabo Hu <[email protected]>
Co-authored-by: dingmeng-xue <[email protected]>
Co-authored-by: msJinLei <[email protected]>
Co-authored-by: msJinLei <[email protected]>
Co-authored-by: kceiw <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>

Author: 8 people

tools/Az.Tools.Predictor/Az.Tools.Predictor.Test/AzPredictorServiceTests.cs

@@ -62,11 +62,12 @@ public AzPredictorServiceTests(ModelFixture fixture)
         public void VerifyUsingSuggestion(string userInput)
         {
             var predictionContext = PredictionContext.Create(userInput);
-            var expected = this._suggestionsPredictor.Query(predictionContext.InputAst, 1, CancellationToken.None);
-            var actual = this._service.GetSuggestion(predictionContext.InputAst, 1, CancellationToken.None);
+            var presentCommands = new System.Collections.Generic.Dictionary<string, int>();
+            var expected = this._suggestionsPredictor.Query(predictionContext.InputAst, presentCommands, 1, 1, CancellationToken.None);
+            var actual = this._service.GetSuggestion(predictionContext.InputAst, 1, 1, CancellationToken.None);
             Assert.NotEmpty(actual);
             Assert.NotNull(actual.First().Item1);
-            Assert.Equal(expected.First().Key, actual.First().Item1);
+            Assert.Equal(expected.Item1.First().Key, actual.First().Item1);
             Assert.Equal(PredictionSource.CurrentCommand, actual.First().Item3);
         }
 
@@ -79,11 +80,12 @@ public void VerifyUsingSuggestion(string userInput)
         public void VerifyUsingCommand(string userInput)
         {
             var predictionContext = PredictionContext.Create(userInput);
-            var expected = this._commandsPredictor.Query(predictionContext.InputAst, 1, CancellationToken.None);
-            var actual = this._service.GetSuggestion(predictionContext.InputAst, 1, CancellationToken.None);
+            var presentCommands = new System.Collections.Generic.Dictionary<string, int>();
+            var expected = this._commandsPredictor.Query(predictionContext.InputAst, presentCommands, 1, 1, CancellationToken.None);
+            var actual = this._service.GetSuggestion(predictionContext.InputAst, 1, 1, CancellationToken.None);
             Assert.NotEmpty(actual);
             Assert.NotNull(actual.First().Item1);
-            Assert.Equal(expected.First().Key, actual.First().Item1);
+            Assert.Equal(expected.Item1.First().Key, actual.First().Item1);
             Assert.Equal(PredictionSource.StaticCommands, actual.First().Item3);
         }
 
@@ -101,7 +103,7 @@ public void VerifyUsingCommand(string userInput)
         public void VerifyNoPrediction(string userInput)
         {
             var predictionContext = PredictionContext.Create(userInput);
-            var actual = this._service.GetSuggestion(predictionContext.InputAst, 1, CancellationToken.None);
+            var actual = this._service.GetSuggestion(predictionContext.InputAst, 1, 1, CancellationToken.None);
             Assert.Empty(actual);
         }
     }

tools/Az.Tools.Predictor/Az.Tools.Predictor.Test/AzPredictorTests.cs

@@ -142,7 +142,7 @@ public void VerifySupportedCommandMasked()
         public void VerifySuggestion(string userInput)
         {
             var predictionContext = PredictionContext.Create(userInput);
-            var expected = this._service.GetSuggestion(predictionContext.InputAst, 1, CancellationToken.None);
+            var expected = this._service.GetSuggestion(predictionContext.InputAst, 1, 1, CancellationToken.None);
             var actual = this._azPredictor.GetSuggestion(predictionContext, CancellationToken.None);
 
             Assert.Equal(expected.Select(e => e.Item1), actual.Select(a => a.SuggestionText));

tools/Az.Tools.Predictor/Az.Tools.Predictor.Test/PredictorTests.cs

@@ -50,8 +50,9 @@ public PredictorTests(ModelFixture fixture)
         public void GetNullPredictionWithCommandName(string userInput)
         {
             var predictionContext = PredictionContext.Create(userInput);
-            var result = this._predictor.Query(predictionContext.InputAst, 1, CancellationToken.None);
-            Assert.Empty(result);
+            var presentCommands = new System.Collections.Generic.Dictionary<string, int>();
+            var result = this._predictor.Query(predictionContext.InputAst, presentCommands, 1, 1, CancellationToken.None);
+            Assert.Empty(result.Item1);
         }
 
         /// <summary>
@@ -66,8 +67,9 @@ public void GetNullPredictionWithCommandName(string userInput)
         public void GetPredictionWithCommandName(string userInput)
         {
             var predictionContext = PredictionContext.Create(userInput);
-            var result = this._predictor.Query(predictionContext.InputAst, 1, CancellationToken.None);
-            Assert.NotEmpty(result);
+            var presentCommands = new System.Collections.Generic.Dictionary<string, int>();
+            var result = this._predictor.Query(predictionContext.InputAst, presentCommands, 1, 1, CancellationToken.None);
+            Assert.NotEmpty(result.Item1);
         }
 
         /// <summary>
@@ -81,8 +83,9 @@ public void GetPredictionWithCommandName(string userInput)
         public void GetPredictionWithCommandNameParameters(string userInput)
         {
             var predictionContext = PredictionContext.Create(userInput);
-            var result = this._predictor.Query(predictionContext.InputAst, 1, CancellationToken.None);
-            Assert.NotEmpty(result);
+            var presentCommands = new System.Collections.Generic.Dictionary<string, int>();
+            var result = this._predictor.Query(predictionContext.InputAst, presentCommands, 1, 1, CancellationToken.None);
+            Assert.NotEmpty(result.Item1);
         }
 
         /// <summary>
@@ -97,8 +100,9 @@ public void GetPredictionWithCommandNameParameters(string userInput)
         public void GetNullPredictionWithCommandNameParameters(string userInput)
         {
             var predictionContext = PredictionContext.Create(userInput);
-            var result = this._predictor.Query(predictionContext.InputAst, 1, CancellationToken.None);
-            Assert.Empty(result);
+            var presentCommands = new System.Collections.Generic.Dictionary<string, int>();
+            var result = this._predictor.Query(predictionContext.InputAst, presentCommands, 1, 1, CancellationToken.None);
+            Assert.Empty(result.Item1);
         }
 
         /// <summary>
@@ -108,9 +112,10 @@ public void GetNullPredictionWithCommandNameParameters(string userInput)
         public void VerifyPredictionForCommand()
         {
             var predictionContext = PredictionContext.Create("Connect-AzAccount");
-            var result = this._predictor.Query(predictionContext.InputAst, 1, CancellationToken.None);
+            var presentCommands = new System.Collections.Generic.Dictionary<string, int>();
+            var result = this._predictor.Query(predictionContext.InputAst, presentCommands, 1, 1, CancellationToken.None);
 
-            Assert.Equal("Connect-AzAccount -Credential <PSCredential> -ServicePrincipal -Tenant <>", result.First().Key);
+            Assert.Equal("Connect-AzAccount -Credential <PSCredential> -ServicePrincipal -Tenant <>", result.Item1.First().Key);
         }
 
         /// <summary>
@@ -120,9 +125,10 @@ public void VerifyPredictionForCommand()
         public void VerifyPredictionForCommandAndParameters()
         {
             var predictionContext = PredictionContext.Create("GET-AZSTORAGEACCOUNTKEY -NAME");
-            var result = this._predictor.Query(predictionContext.InputAst, 1, CancellationToken.None);
+            var presentCommands = new System.Collections.Generic.Dictionary<string, int>();
+            var result = this._predictor.Query(predictionContext.InputAst, presentCommands, 1, 1, CancellationToken.None);
 
-            Assert.Equal("Get-AzStorageAccountKey -Name 'ContosoStorage' -ResourceGroupName 'ContosoGroup02'", result.First().Key);
+            Assert.Equal("Get-AzStorageAccountKey -Name 'ContosoStorage' -ResourceGroupName 'ContosoGroup02'", result.Item1.First().Key);
         }
     }
 }

tools/Az.Tools.Predictor/Az.Tools.Predictor/AzPredictor.cs

@@ -184,7 +184,7 @@ public List<PredictiveSuggestion> GetSuggestion(PredictionContext context, Cance
             {
                 maskedUserInput = AzPredictor.MaskCommandLine(context.InputAst.FindAll((ast) => ast is CommandAst, true).LastOrDefault() as CommandAst);
 
-                suggestions = _service.GetSuggestion(context.InputAst, _settings.SuggestionCount.Value, localCancellationToken);
+                suggestions = _service.GetSuggestion(context.InputAst, _settings.SuggestionCount.Value, _settings.MaxAllowedCommandDuplicate.Value, localCancellationToken);
 
                 localCancellationToken.ThrowIfCancellationRequested();
 

tools/Az.Tools.Predictor/Az.Tools.Predictor/AzPredictorService.cs

@@ -125,14 +125,17 @@ protected virtual void Dispose(bool disposing)
         /// <remarks>
         /// Queries the Predictor with the user input if predictions are available, otherwise uses commands
         /// </remarks>
-        public IEnumerable<ValueTuple<string, string, PredictionSource>> GetSuggestion(Ast input, int suggestionCount, CancellationToken cancellationToken)
+        public IEnumerable<ValueTuple<string, string, PredictionSource>> GetSuggestion(Ast input, int suggestionCount, int maxAllowedCommandDuplicate, CancellationToken cancellationToken)
         {
             var commandSuggestions = this._commandSuggestions;
             var command = this._commandForPrediction;
 
             IList<ValueTuple<string, string, PredictionSource>> results = new List<ValueTuple<string, string, PredictionSource>>();
+            var presentCommands = new System.Collections.Generic.Dictionary<string, int>(); 
+            var resultsFromSuggestionTuple = commandSuggestions?.Item2?.Query(input, presentCommands, suggestionCount, maxAllowedCommandDuplicate, cancellationToken);
+            var resultsFromSuggestion = resultsFromSuggestionTuple.Item1;
+            presentCommands = resultsFromSuggestionTuple.Item2.ToDictionary(kvp => kvp.Key, kvp => kvp.Value);
 
-            var resultsFromSuggestion = commandSuggestions?.Item2?.Query(input, suggestionCount, cancellationToken);
 
             if (resultsFromSuggestion != null)
             {
@@ -159,7 +162,9 @@ public IEnumerable<ValueTuple<string, string, PredictionSource>> GetSuggestion(A
             if ((resultsFromSuggestion == null) || (resultsFromSuggestion.Count() < suggestionCount))
             {
                 var commands = this._commands;
-                var resultsFromCommands = commands?.Query(input, suggestionCount - resultsFromSuggestion.Count(), cancellationToken);
+                var resultsFromCommandsTuple = commands?.Query(input, presentCommands,suggestionCount - resultsFromSuggestion.Count(), maxAllowedCommandDuplicate, cancellationToken);
+                var resultsFromCommands = resultsFromCommandsTuple.Item1;
+                presentCommands = resultsFromCommandsTuple.Item2.ToDictionary(kvp => kvp.Key, kvp => kvp.Value);
 
                 if (resultsFromCommands != null)
                 {

tools/Az.Tools.Predictor/Az.Tools.Predictor/AzPredictorSettings.json

@@ -1,4 +1,5 @@
 {
-  "serviceUri":  "https://app.aladdin.microsoft.com/api/v1",
+  "maxAllowedCommandDuplicate": 1,
+  "serviceUri": "https://app.aladdin.microsoft.com/api/v1",
   "suggestionCount": 7
 }

tools/Az.Tools.Predictor/Az.Tools.Predictor/IAzPredictorService.cs

@@ -29,9 +29,10 @@ public interface IAzPredictorService
         /// </summary>
         /// <param name="input">User input from PSReadLine</param>
         /// <param name="suggestionCount">The number of suggestion to return.</param>
+        /// <param name="maxAllowedCommandDuplicate">The maximum amount of the same commnds in the list of predictions.</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <returns>The list of suggestions for <paramref name="input"/> and the source that create the suggestion. The maximum number of suggestion is <paramref name="suggestionCount"/></returns>
-        public IEnumerable<ValueTuple<string, string, PredictionSource>> GetSuggestion(Ast input, int suggestionCount, CancellationToken cancellationToken);
+        public IEnumerable<ValueTuple<string, string, PredictionSource>> GetSuggestion(Ast input, int suggestionCount, int maxAllowedCommandDuplicate, CancellationToken cancellationToken);
 
         /// <summary>
         /// Requests predictions, given a command string.

tools/Az.Tools.Predictor/Az.Tools.Predictor/Predictor.cs

@@ -57,11 +57,13 @@ public Predictor(IList<string> modelPredictions, ParameterValuePredictor paramet
         /// Given a user input PowerShell AST, returns prediction text.
         /// </summary>
         /// <param name="input">PowerShell AST input of the user, generated by PSReadLine</param>
+        /// <param name="presentCommands">Commands already present.</param>
         /// <param name="suggestionCount">The number of suggestion to return.</param>
+        /// <param name="maxAllowedCommandDuplicate">The maximum amount of the same commnds in the list of predictions.</param>
         /// <param name="cancellationToken">The cancellation token</param>
         /// <returns>The collection of suggestions. The key is the predicted text adjusted based on <paramref name="input"/>. The
         /// value is the original text to create the adjusted text. </returns>
-        public IDictionary<string, string> Query(Ast input, int suggestionCount, CancellationToken cancellationToken)
+        public Tuple<IDictionary<string, string>, IDictionary<string, int>> Query(Ast input, IDictionary<string, int> presentCommands, int suggestionCount, int maxAllowedCommandDuplicate, CancellationToken cancellationToken)
         {
             if (suggestionCount <= 0)
             {
@@ -77,6 +79,7 @@ public IDictionary<string, string> Query(Ast input, int suggestionCount, Cancell
             }
 
             var results = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
+            var resultsTemp = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
 
             try
             {
@@ -102,9 +105,7 @@ public IDictionary<string, string> Query(Ast input, int suggestionCount, Cancell
                 var resultBuilder = new StringBuilder();
                 var usedParams = new HashSet<int>();
                 var sourceBuilder = new StringBuilder();
-                var presentCommands = new System.Collections.Generic.Dictionary<string, int>(); // Added
-                int maxAllowedCommandDupl = 1;
-
+                
                 for (var i = 0; i < _predictions.Count && results.Count < suggestionCount; ++i)
                 {
                     if (commandNameQuery(_predictions[i].Command))
@@ -148,11 +149,15 @@ public IDictionary<string, string> Query(Ast input, int suggestionCount, Cancell
                                     results.Add(prediction.ToString(), sourceBuilder.ToString());
                                     presentCommands.Add(_predictions[i].Command, 1);
                                 }
-                                else if (presentCommands[_predictions[i].Command] < maxAllowedCommandDupl)
+                                else if (presentCommands[_predictions[i].Command] < maxAllowedCommandDuplicate)
                                 {
                                     results.Add(prediction.ToString(), sourceBuilder.ToString());
                                     presentCommands[_predictions[i].Command] += 1;
                                 }
+                                else
+                                {
+                                    resultsTemp.Add(prediction.ToString(), sourceBuilder.ToString());
+                                }
 
                                 if (results.Count == suggestionCount)
                                 {
@@ -166,8 +171,11 @@ public IDictionary<string, string> Query(Ast input, int suggestionCount, Cancell
             catch
             { 
             }
-
-            return results;
+            if ((results.Count < suggestionCount) && (resultsTemp.Count >0))
+            {
+                resultsTemp.ToList().GetRange(0, suggestionCount - results.Count).ForEach(x => results.Add(x.Key,x.Value));
+            }
+            return new Tuple<IDictionary<string, string>, IDictionary<string, int>>(results, presentCommands);
         }
 
         /// <summary>

tools/Az.Tools.Predictor/Az.Tools.Predictor/Settings.cs

@@ -40,6 +40,7 @@ sealed class Settings
         /// The number of suggestions to return to PSReadLine
         /// </summary>
         public int? SuggestionCount { get; set; }
+        public int? MaxAllowedCommandDuplicate { get; set; }
 
         private static bool? _isContinueOnTimeout;
         /// <summary>
@@ -121,6 +122,11 @@ private void OverrideSettingsFromProfile()
                     {
                         this.SuggestionCount = profileSettings.SuggestionCount;
                     }
+
+                    if (profileSettings.MaxAllowedCommandDuplicate.HasValue && (profileSettings.MaxAllowedCommandDuplicate.Value > 0))
+                    {
+                        this.MaxAllowedCommandDuplicate = profileSettings.MaxAllowedCommandDuplicate;
+                    }
                 }
                 catch
                 {