Skip to content

Add Variety to Az.Predictor #13480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 78 commits into from
Nov 20, 2020
Merged

Add Variety to Az.Predictor #13480

merged 78 commits into from
Nov 20, 2020

Conversation

yemohyle
Copy link
Contributor

Description

Fixed issue of duplicate threshold consistency caused by two Query function calls as well as duplicate tolerance when list of novel commands is insufficiently small

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

msJinLei and others added 30 commits August 19, 2020 16:22
* add util functions

* add install-azmodule

* add log to cmdlets

* move verbose messages to debug

* move under tools\

* polish warning message

* move install-azmodule to exports

* export install-azmodule

* rename to az.tools.installer
* add util functions

* add install-azmodule

* add log to cmdlets

* move verbose messages to debug

* move under tools\

* polish warning message

* move install-azmodule to exports

* export install-azmodule

* rename to az.tools.installer

* add uninstall-AzModule
* Update-AzModule

* Address to PM requirements

1. Remove prefix Az. when input module name
2. update calculate from most recently installed respositories of
different modules
3. reorder the sequence of module udpate and uninstall
4. other bug fix
- It contains an implementation of ICommandPredictor that provides
  predictions to PSReadLine.
- It also talks to the service endpoints to get the predictions.
- It reads from the profile settings about the service endpoint.
- There are some tests cases.
@kceiw kceiw self-requested a review November 16, 2020 23:34
kceiw
kceiw previously approved these changes Nov 17, 2020
@dingmeng-xue dingmeng-xue force-pushed the internal/Az.Tools.Predictor branch 2 times, most recently from 2a31e70 to feecabf Compare November 19, 2020 03:31
@dingmeng-xue dingmeng-xue changed the base branch from internal/Az.Tools.Predictor to master November 19, 2020 13:55
@dingmeng-xue dingmeng-xue dismissed kceiw’s stale review November 19, 2020 13:55

The base branch was changed.

@dingmeng-xue dingmeng-xue changed the base branch from master to internal/Az.Tools.Predictor November 19, 2020 14:00
@dingmeng-xue dingmeng-xue changed the base branch from internal/Az.Tools.Predictor to master November 19, 2020 14:09
@dingmeng-xue dingmeng-xue changed the base branch from master to internal/Az.Tools.Predictor November 19, 2020 14:10
@yemohyle yemohyle changed the base branch from internal/Az.Tools.Predictor to master November 19, 2020 22:47
@kceiw kceiw self-requested a review November 19, 2020 23:23
@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dingmeng-xue dingmeng-xue merged commit 221108d into Azure:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants