upgrade Azure.Core to 1.2.2

Author: erich-wang

src/Accounts/Authentication/Utilities/CustomAssemblyResolver.cs

@@ -10,7 +10,7 @@ public static class CustomAssemblyResolver
         private static IDictionary<string, Version> NetFxPreloadAssemblies =
             new Dictionary<string, Version>(StringComparer.InvariantCultureIgnoreCase)
             {
-                {"Azure.Core", new Version("1.2.1.0")},
+                {"Azure.Core", new Version("1.2.2.0")},
                 {"Microsoft.Bcl.AsyncInterfaces", new Version("1.0.0.0")},
                 {"Microsoft.IdentityModel.Clients.ActiveDirectory", new Version("3.19.2.6005")},
                 {"Microsoft.IdentityModel.Clients.ActiveDirectory.Platform", new Version("3.19.2.6005")},

src/lib/NetCorePreloadAssemblies/Azure.Core.dll

@@ -19,6 +19,7 @@
 using System.IO;
 using System.Linq;
 using System.Management.Automation;
+using System.Reflection;
 using System.Text.RegularExpressions;
 using Tools.Common.Issues;
 using Tools.Common.Loaders;
@@ -43,7 +44,7 @@ public HelpAnalyzer()
         public AnalysisLogger Logger { get; set; }
         public string Name { get; private set; }
 
-// TODO: Remove IfDef code
+        // TODO: Remove IfDef code
 #if !NETSTANDARD
         private AppDomain _appDomain;
 #endif
@@ -95,6 +96,7 @@ public void Analyze(IEnumerable<string> scopes, IEnumerable<string> modulesToAna
             var helpLogger = Logger.CreateLogger<HelpIssue>("HelpIssues.csv");
             foreach (var baseDirectory in scopes.Where(s => Directory.Exists(Path.GetFullPath(s))))
             {
+                PreloadSharedAssemblies(baseDirectory);
                 foreach (var directory in Directory.EnumerateDirectories(Path.GetFullPath(baseDirectory)))
                 {
                     if (modulesToAnalyze != null &&
@@ -114,6 +116,30 @@ public void Analyze(IEnumerable<string> scopes, IEnumerable<string> modulesToAna
             }
         }
 
+        private static void PreloadSharedAssemblies(string directory)
+        {
+            var sharedAssemblyFolder = Path.Combine(directory, "Az.Accounts", "NetCoreAssemblies");
+            if (Directory.Exists(sharedAssemblyFolder))
+            {
+                foreach (var file in Directory.GetFiles(sharedAssemblyFolder))
+                {
+                    try
+                    {
+                        Console.WriteLine($"PreloadSharedAssemblies: Starting to load assembly {file}.");
+                        Assembly.LoadFrom(file);
+                    }
+                    catch (Exception e)
+                    {
+                        Console.WriteLine($"PreloadSharedAssemblies: Failed to load assembly {Path.GetFileNameWithoutExtension(file)} with {e}");
+                    }
+                }
+            }
+            else
+            {
+                Console.WriteLine($"PreloadSharedAssemblies: Could not find directory {sharedAssemblyFolder}.");
+            }
+        }
+
         private void AnalyzeMamlHelp(
             IEnumerable<string> scopes,
             string directory,
@@ -158,7 +184,7 @@ private void AnalyzeMamlHelp(
                     h.Assembly = cmdletFileName;
                 }, "Cmdlet");
 
-// TODO: Remove IfDef
+                // TODO: Remove IfDef
 #if NETSTANDARD
                 var proxy = new CmdletLoader();
 #else
@@ -169,7 +195,7 @@ private void AnalyzeMamlHelp(
                 var helpRecords = CmdletHelpParser.GetHelpTopics(helpFile, helpLogger);
                 ValidateHelpRecords(cmdlets, helpRecords, helpLogger);
                 helpLogger.Decorator.Remove("Cmdlet");
-// TODO: Remove IfDef code
+                // TODO: Remove IfDef code
 #if !NETSTANDARD
                 AppDomain.Unload(_appDomain);
 #endif
@@ -229,13 +255,13 @@ private void AnalyzeMarkdownHelp(
             powershell.AddScript(script);
             var cmdletResult = powershell.Invoke();
             var nestedModules = new List<string>();
-            foreach(var module in cmdletResult)
+            foreach (var module in cmdletResult)
             {
-                if(module != null && module.ToString().StartsWith("."))
+                if (module != null && module.ToString().StartsWith("."))
                 {
                     nestedModules.Add(module.ToString().Substring(2));
-                } 
-                else if(module != null)
+                }
+                else if (module != null)
                 {
                     nestedModules.Add(module.ToString());
                 }
@@ -270,7 +296,7 @@ private void AnalyzeMarkdownHelp(
                         h.Assembly = assemblyFileName;
                     }, "Cmdlet");
                     processedHelpFiles.Add(assemblyFileName);
-// TODO: Remove IfDef
+                    // TODO: Remove IfDef
 #if NETSTANDARD
                     var proxy = new CmdletLoader();
 #else
@@ -280,7 +306,7 @@ private void AnalyzeMarkdownHelp(
                     var cmdlets = module.Cmdlets;
                     allCmdlets.AddRange(cmdlets);
                     helpLogger.Decorator.Remove("Cmdlet");
-// TODO: Remove IfDef code
+                    // TODO: Remove IfDef code
 #if !NETSTANDARD
                     AppDomain.Unload(_appDomain);
 #endif
@@ -290,7 +316,7 @@ private void AnalyzeMarkdownHelp(
             script = $"Import-LocalizedData -BaseDirectory {parentDirectory} -FileName {psd1FileName} -BindingVariable ModuleMetadata; $ModuleMetadata.FunctionsToExport;";
             cmdletResult = PowerShell.Create().AddScript(script).Invoke();
             var functionCmdlets = cmdletResult.Select(c => c.ToString()).ToList();
-            foreach(var cmdlet in functionCmdlets)
+            foreach (var cmdlet in functionCmdlets)
             {
                 var metadata = new CmdletMetadata();
                 metadata.VerbName = cmdlet.Split("-")[0];
@@ -302,7 +328,7 @@ private void AnalyzeMarkdownHelp(
             ValidateHelpMarkdown(helpFolder, helpFiles, helpLogger);
 
             Directory.SetCurrentDirectory(savedDirectory);
-            
+
         }
 
         private void ValidateHelpRecords(IList<CmdletMetadata> cmdlets, IList<string> helpRecords,
@@ -321,7 +347,7 @@ private void ValidateHelpRecords(IList<CmdletMetadata> cmdlets, IList<string> he
                         ProblemId = MissingHelp,
                         Remediation = string.Format("Add Help record for cmdlet {0} to help file.", cmdlet.Name)
                     };
-                    if(cmdlet.ClassName != null)
+                    if (cmdlet.ClassName != null)
                     {
                         issue.Description = $"Help missing for cmdlet {cmdlet.Name} implemented by class {cmdlet.ClassName}";
                     }
@@ -335,16 +361,16 @@ private void ValidateHelpRecords(IList<CmdletMetadata> cmdlets, IList<string> he
 
             foreach (var helpRecord in helpRecords)
             {
-                if(!cmdletDict.ContainsKey(helpRecord))
+                if (!cmdletDict.ContainsKey(helpRecord))
                 {
                     Console.Error.WriteLine($"Help record {helpRecord} has no cmdlet.");
-                } 
+                }
             }
         }
 
         private void ValidateHelpMarkdown(string helpFolder, IList<string> helpRecords, ReportLogger<HelpIssue> helpLogger)
         {
-            foreach(var helpMarkdown in helpRecords)
+            foreach (var helpMarkdown in helpRecords)
             {
                 var file = Path.Combine(helpFolder, helpMarkdown + ".md");
                 var content = File.ReadAllText(file);