Skip to content

Commit 47984a6

Browse files
committed
Skipped test that fails on certain NetCore builds. Allowed build to do DLL cleanup again.
1 parent a4f8dcd commit 47984a6

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

build.proj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@
314314
<Exec Command="&quot;$(PowerShellCoreCommand)&quot; -NonInteractive -NoLogo -NoProfile -Command &quot;Set-Variable -Name ProgressPreference -Value 'SilentlyContinue';. $(LibraryToolsFolder)\GenerateHelp.ps1 -GenerateMamlHelp -BuildConfig $(Configuration) &quot;" ContinueOnError="true" Condition=" '$(SkipHelp)' == 'false' and '$(Latest)' == 'true'"/>
315315

316316
<!-- Cleanup extraneous files. -->
317-
<!-- <Exec Command="&quot;$(PowerShellCoreCommand)&quot; -NonInteractive -NoLogo -NoProfile -Command &quot;. $(LibraryToolsFolder)\CleanupBuild.ps1 -BuildConfig $(Configuration) &quot;" /> -->
317+
<Exec Command="&quot;$(PowerShellCoreCommand)&quot; -NonInteractive -NoLogo -NoProfile -Command &quot;. $(LibraryToolsFolder)\CleanupBuild.ps1 -BuildConfig $(Configuration) &quot;" />
318318

319319
<CallTarget Targets="CodeSignBinaries" Condition=" '$(CodeSign)' == 'true' " />
320320
</Target>

src/ResourceManager/Profile/Commands.Profile.Test/AzureRMProfileTests.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,12 @@ public void ProfileSerializeDeserializeWorks()
727727
Assert.Equal("http://insights.contoso.io/", deserializedProfile.DefaultContext.Environment.GetProperty(AzureEnvironment.ExtendedEndpoint.OperationalInsightsEndpointResourceId));
728728
}
729729

730+
#if NETSTANDARD
731+
[Fact(Skip = "Serialized property order changes from NetCore 2.1.2 -> 2.1.200")]
732+
[Trait(Category.RunType, Category.DesktopOnly)]
733+
#else
730734
[Fact]
735+
#endif
731736
[Trait(Category.AcceptanceType, Category.CheckIn)]
732737
public void SavingProfileWorks()
733738
{

0 commit comments

Comments
 (0)