Merge pull request #4815 from v-Ajnava/NovBrkchngSB

ServiceBus: Upcoming Breaking changes - deprecated cmdlets and properties

Author: maddieclayton

src/ResourceManager/ServiceBus/AzureRM.ServiceBus.psd1

@@ -90,25 +90,7 @@ CmdletsToExport = 'New-AzureRmServiceBusNamespace', 'Get-AzureRmServiceBusNamesp
                'New-AzureRmServiceBusKey', 'Get-AzureRmServiceBusKey', 
                'Test-AzureServiceBusName', 'Get-AzureRmServiceBusOperation', 
                'New-AzureRmServiceBusRule', 'Get-AzureRmServiceBusRule', 
-               'Set-AzureRmServiceBusRule', 'Remove-AzureRmServiceBusRule', 
-               'Get-AzureRmServiceBusTopicAuthorizationRule', 
-               'Get-AzureRmServiceBusTopicKey', 
-               'New-AzureRmServiceBusTopicAuthorizationRule', 
-               'New-AzureRmServiceBusTopicKey', 
-               'Remove-AzureRmServiceBusTopicAuthorizationRule', 
-               'Set-AzureRmServiceBusTopicAuthorizationRule', 
-               'New-AzureRmServiceBusNamespaceKey', 
-               'Get-AzureRmServiceBusQueueAuthorizationRule', 
-               'Get-AzureRmServiceBusQueueKey', 
-               'New-AzureRmServiceBusQueueAuthorizationRule', 
-               'New-AzureRmServiceBusQueueKey', 
-               'Remove-AzureRmServiceBusQueueAuthorizationRule', 
-               'Set-AzureRmServiceBusQueueAuthorizationRule', 
-               'Get-AzureRmServiceBusNamespaceAuthorizationRule', 
-               'Get-AzureRmServiceBusNamespaceKey', 
-               'New-AzureRmServiceBusNamespaceAuthorizationRule', 
-               'Remove-AzureRmServiceBusNamespaceAuthorizationRule', 
-               'Set-AzureRmServiceBusNamespaceAuthorizationRule'
+               'Set-AzureRmServiceBusRule', 'Remove-AzureRmServiceBusRule'
 
 # Variables to export from this module
 # VariablesToExport = @()

src/ResourceManager/ServiceBus/ChangeLog.md

@@ -20,6 +20,148 @@
 -->
 ## Current Release
 
+The following cmdlets were affected this release:
+	
+   **Get-AzureRmServiceBusTopicAuthorizationRule**
+	- 'Get-AzureRmServiceBusTopicAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'Get-AzureRmServiceBusAuthorizationRule'
+	
+   **Get-AzureRmServiceBusTopicKey**
+	- 'Get-AzureRmServiceBusTopicKey' cmdlet is removed in current build. Please use the New cmdlet 'Get-AzureRmServiceBusKey'
+	
+   **New-AzureRmServiceBusTopicAuthorizationRule**, 
+	- 'New-AzureRmServiceBusTopicAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'New-AzureRmServiceBusAuthorizationRule'
+	
+   **New-AzureRmServiceBusTopicKey**,
+	- 'New-AzureRmServiceBusTopicKey' cmdlet is removed in current build. Please use the New cmdlet 'New-AzureRmServiceBusKey'
+	
+   **Remove-AzureRmServiceBusTopicAuthorizationRule**, 
+   - 'Remove-AzureRmServiceBusTopicAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'Remove-AzureRmServiceBusAuthorizationRule'
+   
+   **Set-AzureRmServiceBusTopicAuthorizationRule**,
+   - 'Set-AzureRmServiceBusTopicAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'Set-AzureRmServiceBusAuthorizationRule'
+   
+   **New-AzureRmServiceBusNamespaceKey**, 
+   - 'New-AzureRmServiceBusNamespaceKey' cmdlet is removed in current build. Please use the New cmdlet 'New-AzureRmServiceBusKey'
+   
+   **Get-AzureRmServiceBusQueueAuthorizationRule**, 
+   - 'Get-AzureRmServiceBusQueueAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'Get-AzureRmServiceBusAuthorizationRule'
+   
+   **Get-AzureRmServiceBusQueueKey**,
+   - 'Get-AzureRmServiceBusQueueKey' cmdlet is removed in current build. Please use the New cmdlet 'Get-AzureRmServiceBusKey'
+   
+   **New-AzureRmServiceBusQueueAuthorizationRule**, 
+   - 'New-AzureRmServiceBusQueueAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'New-AzureRmServiceBusAuthorizationRule'
+   
+   **New-AzureRmServiceBusQueueKey**,
+   - 'New-AzureRmServiceBusQueueKey' cmdlet is removed in current build. Please use the New cmdlet 'New-AzureRmServiceBusKey'
+   
+   **Remove-AzureRmServiceBusQueueAuthorizationRule**,
+   - 'Remove-AzureRmServiceBusQueueAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'GRemove-AzureRmServiceBusAuthorizationRule'
+   
+   **Set-AzureRmServiceBusQueueAuthorizationRule**, 
+   - 'Set-AzureRmServiceBusQueueAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'Set-AzureRmServiceBusAuthorizationRule'
+   
+   **Get-AzureRmServiceBusNamespaceAuthorizationRule**, 
+   - 'Get-AzureRmServiceBusNamespaceAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'Get-AzureRmServiceBusAuthorizationRule'
+   
+   **Get-AzureRmServiceBusNamespaceKey**, 
+   - 'Get-AzureRmServiceBusNamespaceKey' cmdlet is removed in current build. Please use the New cmdlet 'Get-AzureRmServiceBusKey'
+   
+   **New-AzureRmServiceBusNamespaceAuthorizationRule**,
+   - 'New-AzureRmServiceBusNamespaceAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'New-AzureRmServiceBusAuthorizationRule'
+   
+   **Remove-AzureRmServiceBusNamespaceAuthorizationRule**,
+   - 'Remove-AzureRmServiceBusNamespaceAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'Remove-AzureRmServiceBusAuthorizationRule'
+   
+   **Set-AzureRmServiceBusNamespaceAuthorizationRule**
+   - 'Set-AzureRmServiceBusNamespaceAuthorizationRule' cmdlet is removed in current build. Please use the New cmdlet 'Set-AzureRmServiceBusAuthorizationRule'
+   
+   
+   The following properties are removed in this release:
+   
+
+   **NamespceAttributes**
+   - Status
+   - Enabled
+   
+   ```powershell
+   # Old
+   # The $namespace has Status and Enabled property 
+   $namespace = Get-AzureRmServiceBusNamespace <parameters>
+   $namespace.Status
+   $namespace.Enabled
+   # New
+
+   # The call remains the same, but the returned values NameSpace object will not have the Enabled and Status properties   
+   $namespace = Get-AzureRmServiceBusNamespace <parameters>
+   ```
+
+   **Queue**
+   - EntityAvailabilityStatus
+   - EnableBatchedOperations
+   - IsAnonymousAccessible
+   - SupportOrdering
+
+   ```powershell   
+   # Old
+   # The $queue has EntityAvailabilityStatus, EnableBatchedOperations, IsAnonymousAccessible and SupportOrdering property 
+   $queue = Get-AzureRmServiceBusQueue <parameters>
+   $queue.EntityAvailabilityStatus
+   $queue.EnableBatchedOperations
+   $queue.IsAnonymousAccessible
+   $queue.SupportOrdering	
+
+   # New
+   # The call remains the same, but the returned values Queue object will not have the EntityAvailabilityStatus, EnableBatchedOperations, IsAnonymousAccessible and SupportOrdering properties    
+   $queue = Get-AzureRmServiceBusQueue <parameters>
+   ```
+
+   **Topic**
+   - Location
+   - IsExpress
+   - IsAnonymousAccessible
+   - FilteringMessagesBeforePublishing
+   - EnableSubscriptionPartitioning
+   - EntityAvailabilityStatus
+
+   ```powershell   
+   # Old
+   # The $topic has EntityAvailabilityStatus, EnableSubscriptionPartitioning, IsAnonymousAccessible, IsExpress, Location and FilteringMessagesBeforePublishing property 
+   $topic = Get-AzureRmServiceBusTopic <parameters>
+   $topic.EntityAvailabilityStatus
+   $topic.EnableSubscriptionPartitioning
+   $topic.IsAnonymousAccessible
+   $topic.IsExpress
+   $topic.FilteringMessagesBeforePublishing
+   $topic.Location
+
+   # New
+
+   # The call remains the same, but the returned values Topic object will not have the EntityAvailabilityStatus, EnableSubscriptionPartitioning, IsAnonymousAccessible, IsExpress, FilteringMessagesBeforePublishing and Location properties    
+   $topic = Get-AzureRmServiceBusTopic <parameters>
+   ```   
+
+   **Subscription**
+   - EntityAvailabilityStatus
+   - DeadLetteringOnFilterEvaluationExceptions
+   - Location
+   - IsReadOnly
+
+   ```powershell   
+   # Old
+   # The $subscription has EntityAvailabilityStatus, DeadLetteringOnFilterEvaluationExceptions, Location, and IsReadOnly property 
+   $subscription = Get-AzureRmServiceBussubscription <parameters>
+   $subscription.EntityAvailabilityStatus
+   $subscription.DeadLetteringOnFilterEvaluationExceptions
+   $subscription.Location
+   $subscription.IsReadOnly
+
+   # New
+
+   # The call remains the same, but the returned values Topic object will not have the EntityAvailabilityStatus, DeadLetteringOnFilterEvaluationExceptions, Location, and IsReadOnly properties    
+   $subscription = Get-AzureRmServiceBussubscription <parameters>
+   ```
+
 ## Version 0.4.7
 
 ## Version 0.4.6
@@ -171,4 +313,4 @@
    - Updates properties of existing Subscription of ServiceBus Topic.
 
  - Remove-AzureRmServiceBusSubscription
-   - Deletes existing Subscription of ServiceBus Topic.
+   - Deletes existing Subscription of ServiceBus Topic.

src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/Commands.ServiceBus.Test.csproj

@@ -51,9 +51,8 @@
     <Reference Include="Microsoft.Azure.Common.NetFramework">
       <HintPath>..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.NetFramework.dll</HintPath>
     </Reference>
-    <Reference Include="Microsoft.Azure.Management.Authorization, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <SpecificVersion>False</SpecificVersion>
-      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Authorization.2.0.0\lib\net40\Microsoft.Azure.Management.Authorization.dll</HintPath>
+    <Reference Include="Microsoft.Azure.Management.Authorization">
+      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Authorization.1.0.2\lib\net40\Microsoft.Azure.Management.Authorization.dll</HintPath>
       <Private>True</Private>
     </Reference>
     <Reference Include="Microsoft.Azure.Management.ServiceBus, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">

src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/ScenarioTests/ServiceBusQueueTests.ps1

@@ -80,16 +80,14 @@ function ServiceBusQueueTests
             $found = 1
            Assert-AreEqual $location.Replace(' ','') $createdNamespace.Location.Replace(' ','')
            # Assert-AreEqual $resourceGroupName.ToLower() $createdNamespace.ResourceGroupName.ToLower()
-           # Assert-AreEqual "Messaging" $createdNamespace.NamespaceType
-           
+           # Assert-AreEqual "Messaging" $createdNamespace.NamespaceType           
         }
-    
 
     #Assert-True {$found -eq 0} "Namespace created earlier is not found."
 
 	Write-Debug "Create Queue"
 	$nameQueue = Get-QueueName
-	$result = New-AzureRmServiceBusQueue -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Name $nameQueue -EnablePartitioning $False -MaxDeliveryCount 7
+	$result = New-AzureRmServiceBusQueue -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Name $nameQueue
 	Assert-True {$result.Name -eq $nameQueue} "In CreateQueue response Name not found"
 
 	$resultGetQueue = Get-AzureRmServiceBusQueue -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Name $result.Name
@@ -123,7 +121,6 @@ function ServiceBusQueueTests
 
 	Write-Debug " Delete resourcegroup"
 	Remove-AzureRmResourceGroup -Name $resourceGroupName -Force
-
 }
 
 

src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/ScenarioTests/ServiceBusServiceTests.ps1

@@ -272,7 +272,7 @@ function ServiceBusNameSpaceAuthTests
 
 	$policyKey1 = "SecondaryKey"
 
-	$namespaceRegenerateKeys1 = New-AzureRmServiceBusNamespaceKey -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Name $authRuleName -RegenerateKeys $policyKey1
+	$namespaceRegenerateKeys1 = New-AzureRmServiceBusKey -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Name $authRuleName -RegenerateKey $policyKey1
 	Assert-True {$namespaceRegenerateKeys1.SecondaryKey -ne $namespaceListKeys.SecondaryKey}
 
     Write-Debug "Delete the created Namespace AuthorizationRule"

src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/ScenarioTests/ServiceBusSubscriptionTests.ps1

@@ -115,7 +115,6 @@ function ServiceBusSubscriptionTests
     Assert-True {$resultGetSub.Name -eq $subName} "Subscription created earlier is not found."
 
 	# Update the subscription.
-	$resultGetSub.IsReadOnly = $True
 	$resultSetSub = Set-AzureRmServiceBusSubscription -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Topic $resultGetTopic.Name -InputObject $resultGetSub
 
 	Assert-True {$resultSetSub.Name -eq $resultGetSub.Name} "Subscription Updated earlier is not found."