ServiceBus: Upcoming Breaking changes - deprecated cmdlets and properties #4815

v-Ajnava · 2017-10-18T23:51:29Z

Description

Removed the below cmdlets and properties which were marked as obsolete in previous release:

Get-AzureRmServiceBusTopicAuthorizationRule
Get-AzureRmServiceBusTopicKey
New-AzureRmServiceBusTopicAuthorizationRule
New-AzureRmServiceBusTopicKey
Remove-AzureRmServiceBusTopicAuthorizationRule
Set-AzureRmServiceBusTopicAuthorizationRule
New-AzureRmServiceBusNamespaceKey
Get-AzureRmServiceBusQueueAuthorizationRule
Get-AzureRmServiceBusQueueKey
New-AzureRmServiceBusQueueAuthorizationRule
New-AzureRmServiceBusQueueKey
Remove-AzureRmServiceBusQueueAuthorizationRule
Set-AzureRmServiceBusQueueAuthorizationRule
Get-AzureRmServiceBusNamespaceAuthorizationRule
Get-AzureRmServiceBusNamespaceKey
New-AzureRmServiceBusNamespaceAuthorizationRule
Remove-AzureRmServiceBusNamespaceAuthorizationRule
Set-AzureRmServiceBusNamespaceAuthorizationRule

Properties :
NamespceAttributes -
NamespceAttributes.Status
NamespceAttributes.Enabled

QueueAttirbutes -
QueueAttirbutes.EntityAvailabilityStatus
QueueAttirbutes.EnableBatchedOperations
QueueAttirbutes.IsAnonymousAccessible
QueueAttirbutes.SupportOrdering

TopicAttirbutes -
TopicAttirbutes.Location
TopicAttirbutes.IsExpress
TopicAttirbutes.IsAnonymousAccessible
TopicAttirbutes.FilteringMessagesBeforePublishing
TopicAttirbutes.EnableSubscriptionPartitioning
TopicAttirbutes.EntityAvailabilityStatus

SubscriptionAttributes -
SubscriptionAttributes.EntityAvailabilityStatus
SubscriptionAttributes.DeadLetteringOnFilterEvaluationExceptions
SubscriptionAttributes.Location
SubscriptionAttributes.IsReadOnly

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

…nto NovBrkchngSB # Conflicts: # tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

maddieclayton · 2017-10-23T23:01:08Z

@v-Ajnava Did you delete the cs files for each of the cmdlets that you are removing? I don't see the deleted cmdlets in the PR.

maddieclayton

Some initial comments. Please make sure for every obsoleted property you are removing both the property and every reference to the property (including the parameter inside of cmdlets). Also, please remove the actual cmdlets you are obsoleting.

maddieclayton · 2017-10-23T23:05:30Z

src/ResourceManager/ServiceBus/Commands.ServiceBus/Cmdlets/Queue/NewAzureServiceBusQueue.cs

-#pragma warning disable 612, 618
-            queueAttributes.Location = getNamespaceLoc.Location;
-
-            if (EnableBatchedOperations != null)


Do these parameters serve any purpose now that you have removed this code? If not, please remove the parameters.

removed the parameters

maddieclayton · 2017-10-23T23:07:42Z

...anager/ServiceBus/Commands.ServiceBus/Cmdlets/Subscription/NewAzureServiceBusSubscription.cs

-            if (IsReadOnly != null)
-                subAttributes.IsReadOnly = IsReadOnly;
-            if (DeadLetteringOnFilterEvaluationExceptions != null)
-                subAttributes.DeadLetteringOnFilterEvaluationExceptions = DeadLetteringOnFilterEvaluationExceptions;


Why are you removing the IsReadOnly parameter but not DeadLetteringOnFilterEvaluationExceptions parameter?

removed the parameters

maddieclayton · 2017-10-23T23:17:01Z

src/ResourceManager/ServiceBus/Commands.ServiceBus/Commands.ServiceBus.csproj

@@ -59,26 +59,14 @@
    <Compile Include="Cmdlets\AzureServiceBusCmdletBase.cs" />
    <Compile Include="Cmdlets\CheckNameAvailability\TestAzureServiceBusCheckNameAvailability.cs" />
    <Compile Include="Cmdlets\Namespace\GetAzureServiceBusNamespace.cs" />
-    <Compile Include="Cmdlets\Namespace\GetAzureServiceBusNamespaceAuthorizationRules.cs" />


It looks like you just removed the references to the cmdlets and not the cmdlets themselves.

deleted the class files

maddieclayton · 2017-10-23T23:32:17Z

src/ResourceManager/ServiceBus/Commands.ServiceBus/Models/TopicAttributes.cs

@@ -182,31 +173,6 @@ public TopicAttributes(SBTopic topicResource)
        /// </summary>
        [ObsoleteAttribute("'IsExpress' property is mark as obsolete and will be removed in upcoming breaking changes build", false)]
        public bool? IsExpress { get; set; }
-
-        /// <summary>


Did you mean to leave the Location property?

my bad I missed, removed the properties marked as obsolete.

maddieclayton · 2017-10-23T23:41:28Z

Also @v-Ajnava, please update the change log to reflect the changes you are making (see Cormac's comment in the EventHub PR).

v-Ajnava · 2017-10-24T21:56:08Z

@maddieclayton , updated the changelog.md and resolved the review comments.

…nto NovBrkchngSB # Conflicts: # tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

cormacpayne · 2017-10-25T16:59:07Z

On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/35/

maddieclayton

A few small issues.

maddieclayton · 2017-10-25T17:14:33Z

src/ResourceManager/ServiceBus/ChangeLog.md

+   - Status
+   - Enabled
+
+   ```powershell


fix formatting (check the preview to make sure the formatting looks correct)

I fixed this for you - the markdown file requires special formatting to display correctly. Let me know if you have a problem with these changes.

maddieclayton · 2017-10-25T17:16:29Z

src/ResourceManager/ServiceBus/ChangeLog.md

+	$namespace.Enabled
+    # New
+
+    # The call remains the same, but the returned values NameSpace object will not have the ResourceGroupName property    


It will not have the ResourceGroupName property?

maddieclayton · 2017-10-25T17:17:03Z

src/ResourceManager/ServiceBus/ChangeLog.md

+
+    # New
+
+    # The call remains the same, but the returned values Topic object will not have the EntityAvailabilityStatus, EnableBatchedOperations, IsAnonymousAccessible and SupportOrdering properties    


The properties that you say are missing here don't match the ones you say existed in the old

maddieclayton · 2017-10-25T17:44:43Z

src/ResourceManager/ServiceBus/Commands.ServiceBus/help/Get-AzureRmServiceBusSubscription.md

@@ -121,11 +121,8 @@ AutoDeleteOnIdle                          : 10675199.02:48:05.4775807
 CountDetails                              : Microsoft.Azure.Management.ServiceBus.Models.MessageCountDetails


Take out Location? I believe that was deprecated.

maddieclayton · 2017-10-25T17:45:24Z

src/ResourceManager/ServiceBus/Commands.ServiceBus/help/Get-AzureRmServiceBusTopic.md

@@ -101,18 +101,13 @@ Id                                  : /subscriptions/854d368f-1828-428f-8f3c-f2a
 Type                                : Microsoft.ServiceBus/Topic


Should Location be deleted? It is in the list of deprecated properties. If so, please apply it to this file and all others with SubscriptionAttributes or TopicAttributes

maddieclayton · 2017-10-25T20:28:26Z

https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/38/

v-Ajnava · 2017-10-25T21:50:18Z

@maddieclayton, I pushed the formatting changes for changelog.md. By pushing this, it dismissed your review. can you please take look at the changes

Ajit Maruti Navasare (MINDTREE LIMITED) added 3 commits October 17, 2017 19:56

Breaking changes - depricated cmdlets and properties

d301292

updated the BreakingChangeIssues.csv

dae8797

updated Current Breaking Changes

61db57a

azuresdkci added the needs-review label Oct 19, 2017

azuresdkci assigned cormacpayne Oct 19, 2017

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

03730a0

…nto NovBrkchngSB # Conflicts: # tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

markcowl assigned maddieclayton and cormacpayne and unassigned cormacpayne Oct 23, 2017

maddieclayton suggested changes Oct 23, 2017

View reviewed changes

maddieclayton added needs-revision and removed needs-review labels Oct 23, 2017

maddieclayton assigned v-Ajnava and unassigned cormacpayne and maddieclayton Oct 23, 2017

maddieclayton requested a review from cormacpayne October 23, 2017 23:39

Review comments changes and help files updated

e628dbb

v-Ajnava added needs-review and removed needs-revision labels Oct 24, 2017

Ajit Maruti Navasare (MINDTREE LIMITED) added 2 commits October 24, 2017 17:18

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

3b969dc

…nto NovBrkchngSB # Conflicts: # tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

updated Breakingchanges.csv

321de74

cormacpayne added the Waiting for On Demand label Oct 25, 2017

cormacpayne assigned maddieclayton and unassigned v-Ajnava Oct 25, 2017

maddieclayton suggested changes Oct 25, 2017

View reviewed changes

Resolved review comments for .md files

7d88537

Fix formatting issues with changelog

7f6de64

maddieclayton previously approved these changes Oct 25, 2017

View reviewed changes

maddieclayton removed the needs-review label Oct 25, 2017

Ajit Maruti Navasare (MINDTREE LIMITED) added 2 commits October 25, 2017 14:43

cheangelog.md formating

284ca19

changelog.md formating

d5dae68

v-Ajnava dismissed maddieclayton’s stale review via d5dae68 October 25, 2017 21:45

maddieclayton approved these changes Oct 25, 2017

View reviewed changes

maddieclayton merged commit 576dbf5 into Azure:preview Oct 25, 2017

v-Ajnava deleted the NovBrkchngSB branch April 12, 2018 01:15


		# New

		# The call remains the same, but the returned values Topic object will not have the EntityAvailabilityStatus, EnableBatchedOperations, IsAnonymousAccessible and SupportOrdering properties

		@@ -121,11 +121,8 @@ AutoDeleteOnIdle : 10675199.02:48:05.4775807
		CountDetails : Microsoft.Azure.Management.ServiceBus.Models.MessageCountDetails

		@@ -101,18 +101,13 @@ Id : /subscriptions/854d368f-1828-428f-8f3c-f2a
		Type : Microsoft.ServiceBus/Topic

ServiceBus: Upcoming Breaking changes - deprecated cmdlets and properties #4815

ServiceBus: Upcoming Breaking changes - deprecated cmdlets and properties #4815

Uh oh!

Conversation

v-Ajnava commented Oct 18, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

maddieclayton commented Oct 23, 2017

Uh oh!

maddieclayton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maddieclayton commented Oct 23, 2017

Uh oh!

v-Ajnava commented Oct 24, 2017

Uh oh!

cormacpayne commented Oct 25, 2017

Uh oh!

maddieclayton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maddieclayton commented Oct 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

v-Ajnava commented Oct 25, 2017

Uh oh!

Uh oh!

v-Ajnava commented Oct 18, 2017 •

edited by azuresdkci

Loading

maddieclayton commented Oct 25, 2017 •

edited

Loading