Skip to content

Commit 5dc8d6e

Browse files
authored
Merge pull request #9391 from Nking92/webapp_certificates_rg_filter
Websites - Move the ResourceGroup filtering for GetCertificates to the server
2 parents da1f519 + 1e93fc7 commit 5dc8d6e

File tree

8 files changed

+4527
-4530
lines changed

8 files changed

+4527
-4530
lines changed

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.SSLBindingTests/TagsNotRemovedByCreateNewWebAppSSLBinding.json

Lines changed: 624 additions & 624 deletions
Large diffs are not rendered by default.

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.SSLBindingTests/TestCreateNewWebAppSSLBinding.json

Lines changed: 455 additions & 455 deletions
Large diffs are not rendered by default.

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.SSLBindingTests/TestGetNewWebAppSSLBinding.json

Lines changed: 625 additions & 625 deletions
Large diffs are not rendered by default.

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.SSLBindingTests/TestGetWebAppCertificate.json

Lines changed: 1396 additions & 1396 deletions
Large diffs are not rendered by default.

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.SSLBindingTests/TestRemoveNewWebAppSSLBinding.json

Lines changed: 627 additions & 627 deletions
Large diffs are not rendered by default.

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.SSLBindingTests/TestWebAppSSLBindingPipeSupport.json

Lines changed: 798 additions & 798 deletions
Large diffs are not rendered by default.

src/Websites/Websites/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Optimizes Get-AzWebAppCertificate to filter by resource group on the server instead of the client
2122
* Adds -UseDisasterRecovery switch parameter to Get-AzWebAppSnapshot
2223

2324
## Version 1.2.2

src/Websites/Websites/Utilities/CmdletHelpers.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -394,14 +394,10 @@ internal static Certificate[] GetCertificates(ResourceClient resourceClient, Web
394394
{
395395
var certificateResources = resourceClient.ResourceManagementClient.FilterResources(new FilterResourcesOptions
396396
{
397+
ResourceGroup = resourceGroupName,
397398
ResourceType = "Microsoft.Web/Certificates"
398399
}).ToArray();
399400

400-
if (!string.IsNullOrEmpty(resourceGroupName))
401-
{
402-
certificateResources = certificateResources.Where(c => string.Equals(c.ResourceGroupName, resourceGroupName, StringComparison.OrdinalIgnoreCase)).ToArray();
403-
}
404-
405401
var certificates =
406402
certificateResources.Select(
407403
certificateResource =>

0 commit comments

Comments
 (0)