Skip to content

Websites - Move the ResourceGroup filtering for GetCertificates to the server #9391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nking-1
Copy link

@nking-1 nking-1 commented Jun 7, 2019

Description

This is a small optimization for reading web app certificates from the ARM cache. The resource group filtering is moved to the server side instead of the client side. This will greatly reduce the size of the HTTP response for subscriptions with a large number of certificates.

#9392

Checklist

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a changelog entry. Also, tests are failing, please correct.

@panchagnula
Copy link
Contributor

@markcowl is there a way to get this merged for this current sprint? thank you.

@markcowl markcowl changed the base branch from master to release-2019-06-18 June 12, 2019 19:07
@markcowl markcowl merged commit 5dc8d6e into Azure:release-2019-06-18 Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants