Merge branch 'preview' of https://github.com/Azure/azure-powershell into ResourceCompleter1

Author: azdevxps

CONTRIBUTING.md

@@ -148,7 +148,9 @@ The following guidelines must be followed in **EVERY** pull request that is open
 
 The following guidelines must be followed in pull requests that add, edit, or remove a cmdlet.
 
-- Cmdlet name uses an approved PowerShell verb - use enums for `VerbsCommon`, `VerbsCommunication`, `VerbLifecycle`, `VerbsOther` whenever possible
+- Cmdlet name uses an approved PowerShell verb - use enums for `VerbsCommon`, `VerbsCommunication`, `VerbsData`, `VerbsDiagnostic`, `VerbsLifecycle`, `VerbsOther`, and `VerbsSecurity` whenever possible
+    - Note that you can see a list of all approved PowerShell verbs by running `Get-Verb` in PowerShell
+    - When a verb you would like to use is not in the list of approved verbs, or to get ideas on how to use verbs, consult the [Approved Verbs for Windows PowerShell Commands](https://msdn.microsoft.com/en-us/library/ms714428\(v=vs.85\).aspx) documentation where you will find descriptions of approved verbs as well as related verbs in the comments so that you can find one appropriate for your command
 - Cmdlet noun name uses the AzureRm prefix for management cmdlets, and the Azure prefix for data plane cmdlets
 - Cmdlet specifies the `OutputType` attribute if any output is produced; if the cmdlet produces no output, it should implement a `PassThrough` parameter
 - If the cmdlet makes changes or has side effects, it should implement `ShouldProcess` and have `SupportsShouldProcess = true` specified in the cmdlet attribute. See a discussion about correct `ShouldProcess` implementation [here](https://gist.github.com/markcowl/338e16fe5c8bbf195aff9f8af0db585d#what-is-the-change).

ChangeLog.md

@@ -1,4 +1,37 @@
-## 2017.09.25 - Version 4.4.0
+## 2017.10.12 - Version 4.4.1
+* AzureBatch
+     - Marked cmdlet parameters and type properties obsolete in 
+       preparation for upcoming breaking change release (Version 4.0.0)
+* HDInsight
+    * Added support for Data Disks property in cluster creation
+        - Added parameter 'WorkerNodeDataDisksGroups' to the New-AzureHDInsightCluster cmdlet
+* Insights
+        * Add-AzureRmLogAlertRule
+            - Adding details to deprecation warning introduced in April 2017: the cmdlet will stop having effect: its functionality is moved to the "ActivityLogAlerts" cmdlets.
+            - Help file modified to include the deprecation warning and the details.
+        * Disable-AzureRmActivityLogAlert, Disable-AzureRmActivityLogAlert, Remove-AzureRmActivityLogAlert, Set-AzureRmActivityLogAlert
+            - Help file modified: removed text stating that the Force arguments was accepted since that argument is not accepted.
+* KeyVault
+    * Deprecating the PurgeDisabled flag from Key, Secret and Certificate attributes, respectively.
+      * The flag is being superseded by the RecoveryLevel attribute.
+* MachineLearningCompute
+    * Added initial set of cmdlets for MachineLearningCompute
+        - Get-AzureRmMlOpCluster
+        - Get-AzureRmMlOpClusterKey
+        - New-AzureRmMlOpCluster
+        - Remove-AzureRmMlOpCluster
+        - Test-AzureRmMlOpClusterSystemServicesUpdateAvailability
+        - Update-AzureRmMlOpClusterSystemService
+* MarketplaceOrdering
+    * New Cmdlet Get-AzureRmMarketplaceTerms
+        - Get the agreement terms of a given publisher id, offer id and plan id.
+    * New Cmdlet Set-AzureRmMarketplaceTerms
+    	- Accept or reject agreement terms of a give publisher id, offer id and plan id. Please use Get-AzureRmMarketplaceTerms to get the agreement terms.
+* Profile
+    * LocationCompleterAttribute added and available for cmdlets which use the -Location parameter
+        - Use this feature by adding LocationCompleter(string[] validResourceTypes) onto the Location parameter
+
+## 2017.09.25 - Version 4.4.0
 * AnalysisServices
     * Added a new dataplane commandlet to allow synchronization of databases from read-write instance to read-only instances 
         - Included help file for the commandlet
@@ -3741,4 +3774,4 @@ Virtual Network cmdlets
  * iisnode 0.1.13
 
 2011.12.09 Version 0.5.0
- * Initial Release
+ * Initial Release

TestMappings.json

@@ -70,6 +70,9 @@
     ".\\src\\ResourceManager\\LogicApp\\Commands.LogicApp.Test\\bin\\Debug\\Microsoft.Azure.Commands.LogicApp.Test.dll"
   ],
   "src/ResourceManager/MachineLearning/": [],
+  "src/ResourceManager/MachineLearningCompute/" : [
+     ".\\src\\ResourceManager\\MachineLearningCompute\\Commands.MachineLearningCompute.Test\\bin\\Debug\\Microsoft.Azure.Commands.MachineLearningCompute.Test.dll"
+  ],
   "src/ResourceManager/Media/": [],
   "src/ResourceManager/Network/": [
     ".\\src\\ResourceManager\\Network\\Commands.Network.Test\\bin\\Debug\\Microsoft.Azure.Commands.Network.Test.dll"
@@ -167,5 +170,8 @@
   ],
   "src/ResourceManager/Profile/Commands.Profile.Test/": [
     ".\\src\\ResourceManager\\Profile\\Commands.Profile.Test\\bin\\Debug\\Microsoft.Azure.Commands.Profile.Test.dll"
+  ],
+  "src/ResourceManager/MarketplaceOrdering/Commands.MarketplaceOrdering.Test/": [
+    ".\\src\\ResourceManager\\MarketplaceOrdering\\Commands.MarketplaceOrdering.Test\\bin\\Debug\\Microsoft.Azure.Commands.MarketplaceOrdering.Test.dll"
   ]
 }

documentation/Using-Azure-TestFramework.md

@@ -18,7 +18,7 @@
 	1. This starts VS Dev command prompt in PowerShell
 2. Import module that helps in performing basic repository tasks
 	1. Import-Module Repo-Tasks.psd1
-	2. Type Get-Commands -Module Repo-Tasks to see list of cmdlets
+	2. Type Get-Command -Module Repo-Tasks to see list of cmdlets
 	3. Get-Help <CommandName> to get help on individual commands.
 
 ## 2. Accquring TestFramework

documentation/release-notes/Stack/migration-guide.1.2.11.md

@@ -0,0 +1,251 @@
+# Table of Contents
+1. [Removal of Force parameters](#removal-of-force-parameters)
+2. [Change of Tag parameters](#change-of-tag-parameters)
+3. [Breaking Changes to Profile Cmdlets](#breaking-changes-to-profile-cmdlets)
+
+## Removal of Force parameters
+
+This release, we removed all Obsolete `Force` parameters from cmdlets and the corresponding warnings that the parameter would be removed in a future release.
+
+The following cmdlets are affected by this change:
+
+**Profile**
+- Remove-AzureRmEnvironment
+
+**Resources**
+- Register-AzureRmProviderFeature
+- Register-AzureRmResourceProvider
+- Remove-AzureRmADServicePrincipal
+- Remove-AzureRmPolicyAssignment
+- Remove-AzureRmResourceGroupDeployment
+- Remove-AzureRmRoleAssignment
+- Stop-AzureRmResourceGroupDeployment
+- Unregister-AzureRmResourceProvider
+
+**Tag**
+- Remove-AzureRmTag
+
+<br>
+
+If you have a script that uses any of the above cmdlets, the breaking change can be fixed by simply removing the `Force` parameter.
+
+```powershell
+# Old
+New-AzureRmResourceGroup -Name $resourceGroupName -Location $location -Force
+
+# New
+New-AzureRmResourceGroup -Name $resourceGroupName -Location $location
+```
+
+<br>
+
+## Change of Tag parameters
+
+This release, the `Tags` parameter name was changed to `Tag`, and the type was changed from `Hashtable[]` to `Hashtable`, changing the format of the key-value pairings.
+
+Previously, each entry in the `Hashtable[]` represented a single key-value pairing:
+
+```powershell
+$tags = @{ Name = "test1"; Value = "testval1" }, @{ Name = "test2", Value = "testval2" }
+$tags[0].Name  # Key for the first entry, "test1"
+$tags[0].Value # Value for the first entry, "testval1"
+$tags[1].Name  # Key for the second entry, "test2"
+$tags[1].Value # Value for the second entry, "testval2"
+```
+
+Now, `Name` and `Value` are no longer necessary, allowing for key-value pairings to be created by assigning `Key = "Value"` in the `Hashtable`:
+
+```powershell
+$tag = @{ test1 = "testval1"; test2 = "testval2" }
+$tag["test1"] # Gets the value associated with the key "test1"
+$tag["test2"] # Gets the value associated with the key "test2"
+```
+
+The following cmdlets are affected by this change:
+
+
+**Compute**
+- New-AzureRmVM
+- Update-AzureRmVM
+
+**Dns**
+- New-AzureRmDnsZone
+- Set-AzureRmDnsZone
+
+**KeyVault**
+- Get-AzureRmKeyVault
+- New-AzureRmKeyVault
+
+**Network**
+- New-AzureRmApplicationGateway
+- New-AzureRmExpressRouteCircuit
+- New-AzureRmLoadBalancer
+- New-AzureRmLocalNetworkGateway
+- New-AzureRmNetworkInterface
+- New-AzureRmNetworkSecurityGroup
+- New-AzureRmPublicIpAddress
+- New-AzureRmRouteTable
+- New-AzureRmVirtualNetwork
+- New-AzureRmVirtualNetworkGateway
+- New-AzureRmVirtualNetworkGatewayConnection
+- New-AzureRmVirtualNetworkPeering
+
+**Resources**
+- Find-AzureRmResource
+- Find-AzureRmResourceGroup
+- New-AzureRmResource
+- New-AzureRmResourceGroup
+- Set-AzureRmResource
+- Set-AzureRmResourceGroup
+
+**Storage**
+- New-AzureRmStorageAccount
+- Set-AzureRmStorageAccount
+
+
+<br>
+
+If you have a script that uses any of the above cmdlets, the breaking change can be fixed by changing the `Tags` parameter to `Tag`, as well as changing the `Tag` to the new format.
+
+```powershell
+# Old
+New-AzureRmResourceGroup -Name $resourceGroupName -Location -location -Tags @{ Name = "testtag"; Value = "testval" }
+
+# New
+New-AzureRmResourceGroup -Name $resourceGroupName -Location -location -Tag @{ testtag = "testval" }
+```
+
+<br>
+
+## Breaking Changes to Profile Cmdlets
+
+The following cmdlets and cmdlet output types were changed in this release.
+
+### Add-AzureRmAccount breaking changes
+
+- ```EnvironmentName``` parameter has been removed and replaced with ```Environment```, the ```Environment``` now takes a string and not an ```AzureEnvironment``` object
+
+```powershell
+# Old
+Add-AzureRmAccount -EnvironmentName AzureStack
+
+# New
+Add-AzureRmAccount -Environment AzureStack
+```
+
+### Select-AzureRmProfile was renamed to Import-AzureRmContext
+
+```Select-AzureRmProfile``` was renamed to ```Import-AzureRmContext```
+
+```powershell
+# Old
+Select-AzureRmProfile -Path c:\mydir\myprofile.json
+
+# New
+Import-AzureRmContext -Path c:\mydir\myprofile.json
+```
+
+### Save-AzureRmProfile was renamed to Save-AzureRmContext
+
+```Save-AzureRmProfile``` was renamed to ```Save-AzureRmContext```
+
+```powershell
+# Old
+Save-AzureRmProfile -Path c:\mydir\myprofile.json
+
+# New
+Save-AzureRmContext -Path c:\mydir\myprofile.json
+```
+### Breaking Changes to output PSAzureContext Type
+
+- The ```TokenCache``` property changed to a type that implements ```IAzureTokenCache``` instead of a ```byte[]```
+
+```powershell
+# Old
+$bytes = (Get-AzureRmContext).TokenCache
+$bytes = (Set-AzureRmContext -SubscriptionId xxx-xxx-xxx-xxx).TokenCache
+$bytes = (Add-AzureRmAccount).Context.TokenCache
+
+# New
+$bytes = (Get-AzureRmContext).TokenCache.CacheData
+$bytes = (Set-AzureRmContext -SubscriptionId xxx-xxx-xxx-xxx).TokenCache.CacheData
+$bytes = (Add-AzureRmAccount).Context.TokenCache.CacheData
+```
+
+### Breaking Changes to the output PSAzureAccount Type
+
+- The ```AccountType``` property was changed to ```Type```
+
+```powershell
+# Old
+$type = (Get-AzureRmContext).Account.AccountType
+$type = (Set-AzureRmContext -SubscriptionId xxx-xxx-xxx-xxx).Account.AccountType
+$type = (Add-AzureRmAccount).Context.Account.AccountType
+
+# New 
+$type = (Get-AzureRmContext).Account.Type
+$type = (Set-AzureRmContext -SubscriptionId xxx-xxx-xxx-xxx).Account.Type
+$type = (Add-AzureRmAccount).Context.Account.Type
+```
+
+### Breaking Changes to the output PSAzureSubscription Type
+- The ```SubscriptionId``` property was changed to ```Id```
+
+```powershell
+# Old
+$id =(Get-AzureRmSubscription -SubscriptionId xxxx-xxxx-xxxx-xxxx).SubscriptionId
+$id =(Add-AzureRmAccount -SubscriptionId xxxx-xxxx-xxxx-xxxx).Context.Subscription.SubscriptionId
+$id =(Get-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Subscription.SubscriptionId
+$id =(Set-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Subscription.SubscriptionId
+
+# New
+$id =(Get-AzureRmSubscription -SubscriptionId xxxx-xxxx-xxxx-xxxx).Id
+$id =(Add-AzureRmAccount -SubscriptionId xxxx-xxxx-xxxx-xxxx).Context.Subscription.Id
+$id =(Get-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Subscription.Id
+$id =(Set-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Subscription.Id
+```
+
+- The ```SubscriptionName``` property was changed to ```Name```
+
+```powershell
+# Old
+$name =(Get-AzureRmSubscription -SubscriptionId xxxx-xxxx-xxxx-xxxx).SubscriptionName
+$name =(Add-AzureRmAccount -SubscriptionId xxxx-xxxx-xxxx-xxxx).Context.Subscription.SubscriptionName
+$name =(Get-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Subscription.SubscriptionName
+$name =(Set-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Subscription.SubscriptionName
+
+# New
+$name =(Get-AzureRmSubscription -SubscriptionId xxxx-xxxx-xxxx-xxxx).Name
+$name =(Add-AzureRmAccount -SubscriptionId xxxx-xxxx-xxxx-xxxx).Context.Subscription.Name
+$name =(Get-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Subscription.Name
+$name =(Set-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Subscription.Name
+```
+
+### Breaking Changes to the output PSAzureTenant Type
+
+- The ```TenantId``` property was changed to ```Id```
+
+```powershell
+# Old
+$id =(Get-AzureRmTenant -TenantId xxxx-xxxx-xxxx-xxxx).TenantId
+$id =(Add-AzureRmAccount -SubscriptionId xxxx-xxxx-xxxx-xxxx).Context.Tenant.TenantId
+$id =(Get-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Tenant.TenantId
+$id =(Set-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Tenant.TenantId
+
+# New
+$id =(Get-AzureRmTenant -TenantId xxxx-xxxx-xxxx-xxxx).Id
+$id =(Add-AzureRmAccount -SubscriptionId xxxx-xxxx-xxxx-xxxx).Context.Tenant.Id
+$id =(Get-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Tenant.Id
+$id =(Set-AzureRmContext -SubscriptionId xxxx-xxxx-xxxx-xxxx).Tenant.Id
+```
+
+- The ```Domain``` property was changed to ```Directory```
+
+```powershell
+# Old
+$tenantName =(Get-AzureRmTenant -TenantId xxxx-xxxx-xxxx-xxxx).Domain
+
+# New
+$tenantName =(Get-AzureRmTenant -TenantId xxxx-xxxx-xxxx-xxxx).Directory
+```
+

setup/azurecmd.wxs

@@ -1,11 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi" xmlns:util="http://schemas.microsoft.com/wix/UtilExtension" xmlns:netfx="http://schemas.microsoft.com/wix/NetFxExtension">
 
-  <?define productName="Microsoft Azure PowerShell - September 2017" ?>
+  <?define productName="Microsoft Azure PowerShell - October 2017" ?>
   <?define sourceDir="$(var.SolutionDir)..\src\Package\$(var.Configuration)" ?>
   <?define caSourceDir="$(var.SolutionDir)setup\bin\$(var.Configuration)" ?>
 
-  <?define version="4.4.0" ?>
+  <?define version="4.4.1" ?>
 
   <Product Id="*"
            Name="$(var.productName)"