Merge pull request #5078 from SudhakaraReddyEvuri/suredd-prereqfix

ADE pre-requisite script to pass AAD client secret as a secure string

Author: markcowl

src/ResourceManager/Compute/Commands.Compute/Extension/AzureDiskEncryption/Scripts/AzureDiskEncryptionPreRequisiteSetup.ps1

@@ -62,10 +62,11 @@ $ErrorActionPreference = "Stop"
         $defaultHomePage = 'http://contoso.com';
         $now = [System.DateTime]::Now;
         $oneYearFromNow = $now.AddYears(1);
-        $aadClientSecret = [Guid]::NewGuid();
+        $aadClientSecret = [Guid]::NewGuid().ToString();
+        $secureAadClientSecret = ConvertTo-SecureString -String $aadClientSecret -AsPlainText -Force;
 
         Write-Host "Creating new AAD application ($aadAppName)";
-        $ADApp = New-AzureRmADApplication -DisplayName $aadAppName -HomePage $defaultHomePage -IdentifierUris $identifierUri  -StartDate $now -EndDate $oneYearFromNow -Password $aadClientSecret;
+        $ADApp = New-AzureRmADApplication -DisplayName $aadAppName -HomePage $defaultHomePage -IdentifierUris $identifierUri  -StartDate $now -EndDate $oneYearFromNow -Password $secureAadClientSecret;
         $servicePrincipal = New-AzureRmADServicePrincipal -ApplicationId $ADApp.ApplicationId;
         $SvcPrincipals = (Get-AzureRmADServicePrincipal -SearchString $aadAppName);
         if(-not $SvcPrincipals)