-
Notifications
You must be signed in to change notification settings - Fork 4k
ADE pre-requisite script to pass AAD client secret as a secure string #5078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADE pre-requisite script to pass AAD client secret as a secure string #5078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been able to test this updated syntax and it works well.
@@ -62,10 +62,11 @@ $ErrorActionPreference = "Stop" | |||
$defaultHomePage = 'http://contoso.com'; | |||
$now = [System.DateTime]::Now; | |||
$oneYearFromNow = $now.AddYears(1); | |||
$aadClientSecret = [Guid]::NewGuid(); | |||
$aadClientSecret = [Guid]::NewGuid().ToString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests? Please ensure this is tested end-to-end, and either add covering test automation as part of thisPR, or add a test debt issue in the repo to add test automation for the January release and link the issue here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Mark, this is a sample / example usage script, which was manually validated to be working fine. I sign off based on the manual vaidation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, can we add some validation so that we know when this script fails in the future, or would that be ifficult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened issue #5081 to track this
Description
Update ADE pre-requisite script to pass AAD client secret as a secure string. This is because of a breaking change in New-AzureRmAdApplication cmdlet, plain string is not accepted as client secret anymore.
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines