Skip to content

Commit c516bf1

Browse files
authored
Merge pull request #5110 from wastoresh/storage-v2
Support Set-AzureRMstorageAccount with Kind StorageV2
2 parents 11d15be + 218890d commit c516bf1

File tree

11 files changed

+4594
-18
lines changed

11 files changed

+4594
-18
lines changed

src/ResourceManager/Storage/AzureRM.Storage.psd1

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# RootModule = ''
1313

1414
# Version number of this module.
15-
ModuleVersion = '4.0.1'
15+
ModuleVersion = '4.1.0'
1616

1717
# Supported PSEditions
1818
# CompatiblePSEditions = @()
@@ -122,7 +122,10 @@ PrivateData = @{
122122
# IconUri = ''
123123

124124
# ReleaseNotes of this module
125-
ReleaseNotes = '* Fixed assembly loading issue that caused some cmdlets to fail when executing'
125+
ReleaseNotes = '* Upgrade SRP SDK to 7.1.0
126+
* Add StorageV2 account kind to resource mode storage account cmdlets
127+
- New-AzureRmStorageAccount
128+
- Set-AzureRmStorageAccount'
126129

127130
# External dependent modules of this module
128131
# ExternalModuleDependencies = ''

src/ResourceManager/Storage/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
* Upgrade SRP SDK to 7.1.0
2222
* Add StorageV2 account kind to resource mode storage account cmdlets
2323
- New-AzureRmStorageAccount
24+
- Set-AzureRmStorageAccount
2425

2526
## Version 4.0.1
2627
* Fixed assembly loading issue that caused some cmdlets to fail when executing

src/ResourceManager/Storage/Commands.Management.Storage.Test/Commands.Management.Storage.Test.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,9 @@
200200
<None Include="SessionRecords\Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests.StorageAccountTests\TestStorageAccount.json">
201201
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
202202
</None>
203+
<None Include="SessionRecords\Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests.StorageAccountTests\TestSetAzureStorageAccountStorageV2.json">
204+
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
205+
</None>
203206
</ItemGroup>
204207
<ItemGroup>
205208
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />

src/ResourceManager/Storage/Commands.Management.Storage.Test/ScenarioTests/StorageAccountTests.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,5 +112,11 @@ public void TestNetworkRule()
112112
TestController.NewInstance.RunPsTest("Test-NetworkRule");
113113
}
114114

115+
[Fact]
116+
[Trait(Category.AcceptanceType, Category.CheckIn)]
117+
public void TestSetAzureStorageAccountStorageV2()
118+
{
119+
TestController.NewInstance.RunPsTest("Test-SetAzureStorageAccountStorageV2");
120+
}
115121
}
116122
}

src/ResourceManager/Storage/Commands.Management.Storage.Test/ScenarioTests/StorageAccountTests.ps1

Lines changed: 47 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,6 @@ function Test-SetAzureRmCurrentStorageAccount
520520
}
521521
}
522522

523-
524523
<#
525524
.SYNOPSIS
526525
Test NetworkRule
@@ -611,3 +610,50 @@ function Test-NetworkRule
611610
Clean-ResourceGroup $rgname
612611
}
613612
}
613+
614+
<#
615+
.SYNOPSIS
616+
Test SetAzureStorageAccount with Kind as StorageV2
617+
.Description
618+
AzureAutomationTest
619+
#>
620+
function Test-SetAzureStorageAccountStorageV2
621+
{
622+
# Setup
623+
$rgname = Get-StorageManagementTestResourceName;
624+
625+
try
626+
{
627+
# Test
628+
$stoname = 'sto' + $rgname;
629+
$stotype = 'Standard_GRS';
630+
$loc = Get-ProviderLocation ResourceManagement;
631+
$kind = 'Storage'
632+
633+
New-AzureRmResourceGroup -Name $rgname -Location $loc;
634+
$loc = Get-ProviderLocation_Stage ResourceManagement;
635+
New-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname -Location $loc -Type $stotype -Kind $kind;
636+
637+
Retry-IfException { $global:sto = Get-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname; }
638+
$stotype = 'StandardGRS';
639+
Assert-AreEqual $sto.StorageAccountName $stoname;
640+
Assert-AreEqual $sto.Sku.Name $stotype;
641+
Assert-AreEqual $sto.Location $loc;
642+
Assert-AreEqual $sto.Kind $kind;
643+
644+
$kind = 'StorageV2'
645+
Set-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname -UpgradeToStorageV2;
646+
$sto = Get-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname;
647+
Assert-AreEqual $sto.StorageAccountName $stoname;
648+
Assert-AreEqual $sto.Sku.Name $stotype;
649+
Assert-AreEqual $sto.Location $loc;
650+
Assert-AreEqual $sto.Kind $kind;
651+
652+
Remove-AzureRmStorageAccount -Force -ResourceGroupName $rgname -Name $stoname;
653+
}
654+
finally
655+
{
656+
# Cleanup
657+
Clean-ResourceGroup $rgname
658+
}
659+
}

0 commit comments

Comments
 (0)