-
Notifications
You must be signed in to change notification settings - Fork 4k
Support Set-AzureRMstorageAccount with Kind StorageV2 #5110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Run on-demand again with "-UpgradeToStorageV2" change: |
@@ -21,6 +21,7 @@ | |||
* Upgrade SRP SDK to 7.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blueww Please update the version of the module in AzureRM.Storage.psd1 (should be 4.1.0), please add the text here to the 'ReleaseNotes' in AzureRM.Storage.psd1, and please update the AssemblyVersion and AssemblyFileVersion in AssemblyInfo.cs for the built assembly (Microsoft.Azure.Commands.Management.Storage).
Otherwise, this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl
All updated. Please check.
run on-demand again with version update: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/277/ |
Description
We have already added StorgeV2 support in New-AzureRMStorageAccount.
And this PR add StorageV2 support to Set-AzureRMstorageAccount.
Only Storage/BlobStorage->StorageV2 is supported,
StorageV2->BlobStorage/Storage, BlobStorage<->Storage are not supported by server.
So the validSet of -Kind for Set-AzureRMstorageAccount only has 1 value "StorageV2"
We keep the -Kind in Set-AzureRMstorageAccount as one value allowed string parameter instead of switch parameter, since:
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines