Skip to content

Support Set-AzureRMstorageAccount with Kind StorageV2 #5110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2017

Conversation

blueww
Copy link
Member

@blueww blueww commented Dec 8, 2017

Description

We have already added StorgeV2 support in New-AzureRMStorageAccount.
And this PR add StorageV2 support to Set-AzureRMstorageAccount.

Only Storage/BlobStorage->StorageV2 is supported,
StorageV2->BlobStorage/Storage, BlobStorage<->Storage are not supported by server.

So the validSet of -Kind for Set-AzureRMstorageAccount only has 1 value "StorageV2"
We keep the -Kind in Set-AzureRMstorageAccount as one value allowed string parameter instead of switch parameter, since:

  1. Avoid breaking when add new support kind in the future like StorageV3...
  2. would like to keep the usage of it aligned with the "-Kind" parameter of Add-AzureRMstorageAccount

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@blueww
Copy link
Member Author

blueww commented Dec 8, 2017

@blueww
Copy link
Member Author

blueww commented Dec 12, 2017

Run on-demand again with "-UpgradeToStorageV2" change:
https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/275/

@markcowl markcowl changed the base branch from storage-v2 to AzureRm.Storage.V2 December 12, 2017 03:35
@@ -21,6 +21,7 @@
* Upgrade SRP SDK to 7.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueww Please update the version of the module in AzureRM.Storage.psd1 (should be 4.1.0), please add the text here to the 'ReleaseNotes' in AzureRM.Storage.psd1, and please update the AssemblyVersion and AssemblyFileVersion in AssemblyInfo.cs for the built assembly (Microsoft.Azure.Commands.Management.Storage).

Otherwise, this looks good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl
All updated. Please check.

@blueww
Copy link
Member Author

blueww commented Dec 12, 2017

@markcowl
Copy link
Member

@markcowl markcowl merged commit c516bf1 into Azure:AzureRm.Storage.V2 Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants