update Az.Compute to use latest Compute SDK (#15511)

* updating compute sdk reference,  and SecurityType parameter type changes from 'SecurityType" to "string"  end user experience stays the same.

* add argument Completers for enum parameter

* changelog

* fix small bug in Set-AzVmsssecurityProfile

* suppressing non-customer impacting breaking changes from SDK

* update breaking change csv

Author: grizzlytheodore

src/Compute/Compute.Test/Compute.Test.csproj

@@ -12,7 +12,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Azure.Graph.RBAC" Version="3.4.0-preview" />
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="3.1.0-preview.2" />
     <PackageReference Include="Microsoft.Azure.Management.Network" Version="20.5.0" />
   </ItemGroup>

src/Compute/Compute/ChangeLog.md

@@ -22,6 +22,7 @@
 ## Upcoming Release
 * Fixed the warning in `New-AzVM` cmdlet stating the sku of the VM is being defaulted even if a sku size is provided by the user. Now it only occurs when the user does not provide a sku size.
 * Edited `Set-AzVmOperatingSystem` cmdlet to no longer overwrite any existing EnableAutomaticUpdates value on the passed in virtual machine if it exists.
+* Updated Compute module to use the latest .Net SDK version 48.0.0.
 
 ## Version 4.15.0
 * Added optional parameter `-OrchestrationMode` to `New-AzVmss` and `New-AzVmssConfig`

src/Compute/Compute/Compute.csproj

@@ -13,7 +13,7 @@
 
   <ItemGroup>
     <PackageReference Include="AutoMapper" Version="6.2.2" />
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
     <PackageReference Include="System.Security.Permissions" Version="4.5.0" />
     <PackageReference Include="System.ServiceModel.Primitives" Version="4.4.1" />
     <PackageReference Include="WindowsAzure.Storage" Version="9.3.0" />

src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/SetAzureRmVmssSecurityProfileCommand.cs

@@ -27,6 +27,7 @@
 using Microsoft.Azure.Commands.Compute.Automation.Models;
 using Microsoft.Azure.Management.Compute.Models;
 using Microsoft.WindowsAzure.Commands.Utilities.Common;
+using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 
 namespace Microsoft.Azure.Commands.Compute.Automation
 {
@@ -46,7 +47,8 @@ public partial class SetAzureRmVmssSecurityProfileCommand : Microsoft.Azure.Comm
             Mandatory = false,
             Position = 1,
             ValueFromPipelineByPropertyName = true)]
-        public SecurityTypes SecurityType { get; set; }
+        [PSArgumentCompleter("TrustedLaunch")]
+        public string SecurityType { get; set; }
 
         protected override void ProcessRecord()
         {
@@ -58,13 +60,16 @@ private void Run()
             if (this.IsParameterBound(c => c.SecurityType))
             {
                 // Security Profile
+                if (this.VirtualMachineScaleSet.VirtualMachineProfile == null)
+                {
+                    this.VirtualMachineScaleSet.VirtualMachineProfile = new PSVirtualMachineScaleSetVMProfile();
+                }
                 if (this.VirtualMachineScaleSet.VirtualMachineProfile.SecurityProfile == null)
                 {
                     this.VirtualMachineScaleSet.VirtualMachineProfile.SecurityProfile = new SecurityProfile();
                 }
-                this.VirtualMachineScaleSet.VirtualMachineProfile.SecurityProfile.SecurityType = SecurityType;
+                this.VirtualMachineScaleSet.VirtualMachineProfile.SecurityProfile.SecurityType = this.SecurityType;
             }
-
             WriteObject(this.VirtualMachineScaleSet);
         }
 

src/Compute/Compute/VirtualMachine/Config/SetAzureVMSecurityProfile.cs

@@ -20,6 +20,7 @@
 using Microsoft.Azure.Commands.Compute.Common;
 using Microsoft.Azure.Commands.Compute.Models;
 using Microsoft.Azure.Management.Compute.Models;
+using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 
 namespace Microsoft.Azure.Commands.Compute
 {
@@ -39,7 +40,8 @@ public class SetAzureVMSecurityProfile : Microsoft.Azure.Commands.ResourceManage
         [Parameter(
            Mandatory = false,
            ValueFromPipelineByPropertyName = true)]
-        public SecurityTypes SecurityType { get; set; }
+        [PSArgumentCompleter("TrustedLaunch")]
+        public string SecurityType { get; set; }
 
         public override void ExecuteCmdlet()
         {

src/Network/Network.Test/Network.Test.csproj

@@ -18,7 +18,7 @@
     <PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.5" />
     <PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="3.1.0-preview.2" />
     <PackageReference Include="Microsoft.Azure.Insights" Version="0.16.0-preview" />
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.PrivateDns" Version="1.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.Redis" Version="4.4.1" />
     <PackageReference Include="Microsoft.Azure.Management.OperationalInsights" Version="0.21.0-preview" />

src/RecoveryServices/RecoveryServices.Backup.Test/RecoveryServices.Backup.Test.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <PsModuleName>RecoveryServices.Backup</PsModuleName>
@@ -11,7 +11,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.Network" Version="20.5.0" />
     <PackageReference Include="Microsoft.Azure.Management.RecoveryServices" Version="4.3.1-preview" />
 	<PackageReference Include="Microsoft.Azure.Management.RecoveryServices.Backup" Version="4.1.6-preview" />

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/RecoveryServices.SiteRecovery.Test.csproj

@@ -11,7 +11,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.Network" Version="20.5.0" />
     <PackageReference Include="Microsoft.Azure.Management.RecoveryServices" Version="4.3.1-preview" />
 	<PackageReference Include="Microsoft.Azure.Management.RecoveryServices.Backup" Version="4.1.6-preview" />

src/Security/Security.Test/Security.Test.csproj

@@ -42,7 +42,7 @@
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
     <PackageReference Include="Microsoft.Azure.Management.SecurityCenter" Version="2.2.0" />
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.OperationalInsights" Version="0.21.0-preview" />
   </ItemGroup>
 </Project>

src/SqlVirtualMachine/SqlVirtualMachine.Test/SqlVirtualMachine.Test.csproj

@@ -15,7 +15,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.Network" Version="20.5.0" />
     <PackageReference Include="Microsoft.Azure.Management.Storage" Version="13.1.0" />
     <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="3.8.0-preview" />

tools/StaticAnalysis/Exceptions/Az.Compute/BreakingChangeIssues.csv

@@ -0,0 +1,6 @@
+"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
+"Az.Compute","Microsoft.Azure.Commands.Compute.NewAzureAdditionalUnattendContentCommand","Add-AzVMAdditionalUnattendContent","0","3010","The property 'PublicIPAddressSkuName' of type 'Microsoft.Azure.Management.Compute.Models.PublicIPAddressSku' has been removed.","Add the property 'PublicIPAddressSkuName' back to type 'Microsoft.Azure.Management.Compute.Models.PublicIPAddressSku'."
+"Az.Compute","Microsoft.Azure.Commands.Compute.NewAzureAdditionalUnattendContentCommand","Add-AzVMAdditionalUnattendContent","0","3010","The property 'PublicIPAddressSkuTier' of type 'Microsoft.Azure.Management.Compute.Models.PublicIPAddressSku' has been removed.","Add the property 'PublicIPAddressSkuTier' back to type 'Microsoft.Azure.Management.Compute.Models.PublicIPAddressSku'."
+"Az.Compute","Microsoft.Azure.Commands.Compute.NewAzureAdditionalUnattendContentCommand","Add-AzVMAdditionalUnattendContent","0","3000","The type of property 'SecurityType' of type 'Microsoft.Azure.Management.Compute.Models.SecurityProfile' has changed from 'System.Nullable`1[Microsoft.Azure.Management.Compute.Models.SecurityTypes]' to 'System.String'.","Change the type of property 'SecurityType' back to 'System.Nullable`1[Microsoft.Azure.Management.Compute.Models.SecurityTypes]'."
+"Az.Compute","Microsoft.Azure.Commands.Compute.SetAzureVMSecurityProfile","Set-AzVMSecurityProfile","0","2020","The cmdlet 'Set-AzVMSecurityProfile' no longer supports the type 'Microsoft.Azure.Management.Compute.Models.SecurityTypes' for parameter 'SecurityType'.","Change the type for parameter 'SecurityType' back to 'Microsoft.Azure.Management.Compute.Models.SecurityTypes'."
+"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.SetAzureRmVmssSecurityProfileCommand","Set-AzVmssSecurityProfile","0","2020","The cmdlet 'Set-AzVmssSecurityProfile' no longer supports the type 'Microsoft.Azure.Management.Compute.Models.SecurityTypes' for parameter 'SecurityType'.","Change the type for parameter 'SecurityType' back to 'Microsoft.Azure.Management.Compute.Models.SecurityTypes'."