Skip to content

update Az.Compute to use latest Compute SDK #15511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 23, 2021
Merged

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Jul 21, 2021

…ges from 'SecurityType" to "string" end user experience stays the same.

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

…es from 'SecurityType" to "string" end user experience stays the same.
@grizzlytheodore
Copy link
Member Author

SecurityType parameter type changed from "SecurityType" to "string".
because this enum property in Swagger went from modelAsString: false to true.
shown here Azure/azure-rest-api-specs@9c4f909

but the end user experience should stay the same.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BreakingChangeIssues.csv is in wrong format -- each cell should be double-quoted -- make sure you copied them from the csv files in the artifacts of a failed pipeline, not from the logs.

@grizzlytheodore
Copy link
Member Author

grizzlytheodore commented Jul 22, 2021

please review again ! @isra-fel

@isra-fel isra-fel merged commit e45b532 into main Jul 23, 2021
@isra-fel isra-fel deleted the cplat_updateComputeSDK branch July 23, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants