Skip to content

update Az.Compute to use latest Compute SDK #15511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 23, 2021
Merged

update Az.Compute to use latest Compute SDK #15511

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a6f523
updating compute sdk reference, and SecurityType parameter type chan…
grizzlytheodore Jul 21, 2021
671a218
add argument Completers for enum parameter
grizzlytheodore Jul 21, 2021
749ba52
changelog
grizzlytheodore Jul 21, 2021
2c4d6f1
fix small bug in Set-AzVmsssecurityProfile
grizzlytheodore Jul 21, 2021
f9190f8
suppressing non-customer impacting breaking changes from SDK
grizzlytheodore Jul 21, 2021
83c1462
update breaking change csv
grizzlytheodore Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compute/Compute.Test/Compute.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Graph.RBAC" Version="3.4.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
<PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="3.1.0-preview.2" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="20.5.0" />
</ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Compute/Compute/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
## Upcoming Release
* Fixed the warning in `New-AzVM` cmdlet stating the sku of the VM is being defaulted even if a sku size is provided by the user. Now it only occurs when the user does not provide a sku size.
* Edited `Set-AzVmOperatingSystem` cmdlet to no longer overwrite any existing EnableAutomaticUpdates value on the passed in virtual machine if it exists.
* Updated Compute module to use the latest .Net SDK version 48.0.0.

## Version 4.15.0
* Added optional parameter `-OrchestrationMode` to `New-AzVmss` and `New-AzVmssConfig`
Expand Down
2 changes: 1 addition & 1 deletion src/Compute/Compute/Compute.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<ItemGroup>
<PackageReference Include="AutoMapper" Version="6.2.2" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
<PackageReference Include="System.Security.Permissions" Version="4.5.0" />
<PackageReference Include="System.ServiceModel.Primitives" Version="4.4.1" />
<PackageReference Include="WindowsAzure.Storage" Version="9.3.0" />
Expand Down
11 changes: 8 additions & 3 deletions ...e/Compute/Generated/VirtualMachineScaleSet/Config/SetAzureRmVmssSecurityProfileCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
using Microsoft.Azure.Commands.Compute.Automation.Models;
using Microsoft.Azure.Management.Compute.Models;
using Microsoft.WindowsAzure.Commands.Utilities.Common;
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;

namespace Microsoft.Azure.Commands.Compute.Automation
{
Expand All @@ -46,7 +47,8 @@ public partial class SetAzureRmVmssSecurityProfileCommand : Microsoft.Azure.Comm
Mandatory = false,
Position = 1,
ValueFromPipelineByPropertyName = true)]
public SecurityTypes SecurityType { get; set; }
[PSArgumentCompleter("TrustedLaunch")]
public string SecurityType { get; set; }

protected override void ProcessRecord()
{
Expand All @@ -58,13 +60,16 @@ private void Run()
if (this.IsParameterBound(c => c.SecurityType))
{
// Security Profile
if (this.VirtualMachineScaleSet.VirtualMachineProfile == null)
{
this.VirtualMachineScaleSet.VirtualMachineProfile = new PSVirtualMachineScaleSetVMProfile();
}
if (this.VirtualMachineScaleSet.VirtualMachineProfile.SecurityProfile == null)
{
this.VirtualMachineScaleSet.VirtualMachineProfile.SecurityProfile = new SecurityProfile();
}
this.VirtualMachineScaleSet.VirtualMachineProfile.SecurityProfile.SecurityType = SecurityType;
this.VirtualMachineScaleSet.VirtualMachineProfile.SecurityProfile.SecurityType = this.SecurityType;
}

WriteObject(this.VirtualMachineScaleSet);
}

Expand Down
4 changes: 3 additions & 1 deletion src/Compute/Compute/VirtualMachine/Config/SetAzureVMSecurityProfile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
using Microsoft.Azure.Commands.Compute.Common;
using Microsoft.Azure.Commands.Compute.Models;
using Microsoft.Azure.Management.Compute.Models;
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;

namespace Microsoft.Azure.Commands.Compute
{
Expand All @@ -39,7 +40,8 @@ public class SetAzureVMSecurityProfile : Microsoft.Azure.Commands.ResourceManage
[Parameter(
Mandatory = false,
ValueFromPipelineByPropertyName = true)]
public SecurityTypes SecurityType { get; set; }
[PSArgumentCompleter("TrustedLaunch")]
public string SecurityType { get; set; }

public override void ExecuteCmdlet()
{
Expand Down
2 changes: 1 addition & 1 deletion src/Network/Network.Test/Network.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.5" />
<PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="3.1.0-preview.2" />
<PackageReference Include="Microsoft.Azure.Insights" Version="0.16.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
<PackageReference Include="Microsoft.Azure.Management.PrivateDns" Version="1.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Redis" Version="4.4.1" />
<PackageReference Include="Microsoft.Azure.Management.OperationalInsights" Version="0.21.0-preview" />
Expand Down
4 changes: 2 additions & 2 deletions src/RecoveryServices/RecoveryServices.Backup.Test/RecoveryServices.Backup.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<PsModuleName>RecoveryServices.Backup</PsModuleName>
Expand All @@ -11,7 +11,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="20.5.0" />
<PackageReference Include="Microsoft.Azure.Management.RecoveryServices" Version="4.3.1-preview" />
<PackageReference Include="Microsoft.Azure.Management.RecoveryServices.Backup" Version="4.1.6-preview" />
Expand Down
2 changes: 1 addition & 1 deletion ...veryServices/RecoveryServices.SiteRecovery.Test/RecoveryServices.SiteRecovery.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="20.5.0" />
<PackageReference Include="Microsoft.Azure.Management.RecoveryServices" Version="4.3.1-preview" />
<PackageReference Include="Microsoft.Azure.Management.RecoveryServices.Backup" Version="4.1.6-preview" />
Expand Down
2 changes: 1 addition & 1 deletion src/Security/Security.Test/Security.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<PackageReference Include="Microsoft.Azure.Management.SecurityCenter" Version="2.2.0" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
<PackageReference Include="Microsoft.Azure.Management.OperationalInsights" Version="0.21.0-preview" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/SqlVirtualMachine/SqlVirtualMachine.Test/SqlVirtualMachine.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="47.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="48.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="20.5.0" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="13.1.0" />
<PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="3.8.0-preview" />
Expand Down
6 changes: 6 additions & 0 deletions tools/StaticAnalysis/Exceptions/Az.Compute/BreakingChangeIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
AssemblyFileName,ClassName,Target,Severity,ProblemId,Description,Remediation
Az.Compute,Microsoft.Azure.Commands.Compute.NewAzureAdditionalUnattendContentCommand,Add-AzVMAdditionalUnattendContent,0,3010,The property 'PublicIPAddressSkuName' of type 'Microsoft.Azure.Management.Compute.Models.PublicIPAddressSku' has been removed.,Add the property 'PublicIPAddressSkuName' back to type 'Microsoft.Azure.Management.Compute.Models.PublicIPAddressSku'.
Az.Compute,Microsoft.Azure.Commands.Compute.NewAzureAdditionalUnattendContentCommand,Add-AzVMAdditionalUnattendContent,0,3010,The property 'PublicIPAddressSkuTier' of type 'Microsoft.Azure.Management.Compute.Models.PublicIPAddressSku' has been removed.,Add the property 'PublicIPAddressSkuTier' back to type 'Microsoft.Azure.Management.Compute.Models.PublicIPAddressSku'.
Az.Compute,Microsoft.Azure.Commands.Compute.NewAzureAdditionalUnattendContentCommand,Add-AzVMAdditionalUnattendContent,0,3000,The type of property 'SecurityType' of type 'Microsoft.Azure.Management.Compute.Models.SecurityProfile' has changed from 'System.Nullable`1[Microsoft.Azure.Management.Compute.Models.SecurityTypes]' to 'System.String'.,Change the type of property 'SecurityType' back to 'System.Nullable`1[Microsoft.Azure.Management.Compute.Models.SecurityTypes]'.
Az.Compute,Microsoft.Azure.Commands.Compute.SetAzureVMSecurityProfile,Set-AzVMSecurityProfile,0,2020,The cmdlet 'Set-AzVMSecurityProfile' no longer supports the type 'Microsoft.Azure.Management.Compute.Models.SecurityTypes' for parameter 'SecurityType'.,Change the type for parameter 'SecurityType' back to 'Microsoft.Azure.Management.Compute.Models.SecurityTypes'.
Az.Compute,Microsoft.Azure.Commands.Compute.Automation.SetAzureRmVmssSecurityProfileCommand,Set-AzVmssSecurityProfile,0,2020,The cmdlet 'Set-AzVmssSecurityProfile' no longer supports the type 'Microsoft.Azure.Management.Compute.Models.SecurityTypes' for parameter 'SecurityType'.,Change the type for parameter 'SecurityType' back to 'Microsoft.Azure.Management.Compute.Models.SecurityTypes'.